Repository navigation
chore: log the HTTP client steps at FINE and keep the FINE logs of CI test runs - #1602
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new log runs before the completed-exchange guard, causing normal HTTP/2 and HTTP/3 stream teardown to emit misleading failure messages and stack traces after successful exchanges.
1 open issue
What changed in this PR
This PR adds diagnostics for intermittent HTTP client failures tracked in #1601. It expands Netty logging and preserves CI test logs for investigation; it does not fix the underlying failure.
Changes:
- Adds FINE logs for connection lifecycle events and request/response exchanges.
- Introduces a CI logging profile that writes detailed Restlet logs while keeping console output at INFO.
- Uploads logs and test reports after CI failures and documents the change.
| File | Description |
|---|---|
org.restlet/src/test/ci-logging.properties |
Configures INFO console output and FINE file logging. |
org.restlet/src/main/java/org/restlet/engine/netty/NettyClientHelper.java |
Logs connection creation, reuse, pooling, and closure. |
org.restlet/src/main/java/org/restlet/engine/netty/NettyClientCall.java |
Logs request sending, response receipt, and exchange failures. |
org.restlet/pom.xml |
Adds the ci-logging test profile. |
changes.md |
Records the new diagnostics and CI log retention. |
.github/workflows/build.yaml |
Enables CI logging and uploads diagnostic artifacts on failure. |
Review effort: Balanced
jlouvel
force-pushed
the
chore/security-test-client-logging
branch
from
November 1, 2026 14:22
696987b to
0e1ab36
Compare
To diagnose the intermittent Communication Error (1001) of SecurityTestCase, the Netty client logs at FINE each connection opened, reused, discarded or closed, each request sent, each response head and end received, and each exchange failure. The new "ci-logging" profile writes the FINE logs of the core tests to target/restlet-fine.log, which CI uploads when the build fails. Refs #1601 Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
… logs The client call now logs the end of the response through its helper. Co-Authored-By: Claude Opus 5.5 <[email protected]>
jlouvel
force-pushed
the
chore/security-test-client-logging
branch
from
November 1, 2026 17:16
0e1ab36 to
0f66c6d
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Refs #1601.
SecurityTestCasesometimes getsCommunication Error (1001)instead of a 401/403 in CI. The client logs only the finalIOException, and only at FINE, which CI doesn't enable, so we can't see which step fails. This PR doesn't fix the failure. It makes the next one diagnosable.Changes
NettyClientHelperlogs at FINE each connection:reusableflag)NettyClientCalllogs at FINE:Every message includes the Netty channel, which shows the id and the local and remote ports. The messages are suppliers, so they cost nothing when FINE is off.
org.restlet/pom.xml: newci-loggingprofile. It points thedefault-testexecution tosrc/test/ci-logging.properties. That config keeps the console at INFO, and writes the FINE logs of theorg.restletloggers toorg.restlet/target/restlet-fine.log.build.yaml: the build uses-P default,test,ci-logging. When the build fails, a new step uploads the log and the surefire reports as thetest-logsartifact.changes.md: entry under Misc.Notes
org.restletwith the profile: the log is 1.8 MB, about 15k lines.ShutdownHookTestCase.whenServerIsHandlingBlockingRequestThenItRefusesNewRequestfailed locally on Windows, with and without the profile. Its ±200 ms timing tolerance is too tight on this machine, so the failure is unrelated to this change. All 2214 other tests passed.java.util.logging.config.fileturnsEngine.configureLog()into a no-op for those test runs. No test depends on it:ConnectorTestCaseonly sets the INFO level, which the config already uses.How to read a failure
Download the
test-logsartifact, then searchrestlet-fine.logfor the port in the failing test's URI (R:localhost/127.0.0.1:<port>). The sequence shows whether the request went on a reused connection, whether the response head arrived, and when the connection closed relative to the failure.🤖 Generated with Claude Code