Repository navigation
test: drop the server write failure check in Http2CancellationTestCase - #1576
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the change narrowing the HTTP/2 cancellation test to client-side abort behavior.
No open issues 🎉
What changed in this PR
This PR narrows the HTTP/2 cancellation test to client-side abort behavior, removing the requirement that the server’s response write fail.
Changes:
- Removes the server-write failure latch, exception tracking, and timed assertion.
- Preserves checks for the communication-error status, repeated callback notification, and response-body read failure.
| File | Description |
|---|---|
org.restlet/src/test/java/org/restlet/engine/connector/Http2CancellationTestCase.java |
Removes server-write failure verification while retaining client-side cancellation assertions. |
Review effort: Balanced
abortFailsTheResponseStreamAndNotifiesTheResponseCallback no longer waits for the server-side response write to fail after the client aborts. The test still checks that the abort fails the client response stream and notifies the response callback. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: Jerome Louvel <[email protected]>
jlouvel
force-pushed
the
test/http2-cancellation-write-failure
branch
from
November 1, 2026 14:32
25b10cd to
838a30a
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
abortFailsTheResponseStreamAndNotifiesTheResponseCallbackno longer waits for the server-side response write to fail after the client aborts the HTTP/2 response.The test still checks the client side of the abort:
CONNECTOR_ERROR_COMMUNICATION.IOException.Testing
Http2CancellationTestCasepasses locally.🤖 Generated with Claude Code