[jlouvel]

Summary

WebSocketClient in the experimental org.restlet.ext.websocket extension was configured through a fluent Builder. This PR switches it to the Restlet API conventions used by the RPC extensions (MCP, gRPC, Smithy): a constructor, getter and void setter pairs, and a start() / stop() lifecycle.

WebSocketClient client = new WebSocketClient();
client.setConnectTimeout(Duration.ofSeconds(5));
client.setMaxMessageSize(1 << 20);
try (client; WebSocketSession session = client.connect("ws://host/")) {
    ...
}

Changes

• Removed WebSocketClient.Builder, builder() and create(). Each setting is now a getter/setter pair: SslContext, ConnectTimeout, IdleTimeout, MaxMessageSize, MaxFrameSize, Compression and HostnameVerification.
• Added start(), stop() and isStarted(). start() creates the I/O threads and stop() releases them. close() calls stop(), and a stopped client can be started again.
• connect() starts a stopped client, like Restlet.handle().
• Changing a setting while the client is started throws IllegalStateException.
• getMaxFrameSize() returns the maximum message size until a frame size is set, the same default as before.

The extension has not been released yet, so the builder is removed rather than deprecated.

Testing

• Updated the existing tests to the new API. Renamed builderValidatesSettings to clientValidatesSettings and added settingsAreFixedWhileStarted.
• mvn -pl org.restlet.ext.websocket verify passes locally: 28 tests, no failures.

Not in this PR

The client still creates its own Netty event loop instead of borrowing one from the application's connector. That is a separate, larger change.

🤖 Generated with Claude Code

[Copilot]

🟡 Changes recommended

The public API migration lacks a breaking-change entry, and the same-instance stop/reconfigure/reconnect lifecycle lacks integration-test coverage.

2 open issues

• Document the breaking API and lifecycle changes · New
• Test reconnecting with updated settings on the same client · New

What changed in this PR

This PR replaces the experimental WebSocket client’s builder API with constructor-based configuration and setters, aligning it with the Restlet RPC extensions.

Changes:

• Adds getters and setters, with configuration changes blocked while the client is started.
• Introduces a restartable lifecycle and automatic startup on connection.
• Migrates existing tests and adds configuration validation and lifecycle-state checks.

File	Description
org.restlet.ext.websocket/​src/​test/​java/​org/​restlet/​ext/​websocket/​WebSocketTestCase.java	Updates shared client setup to use setters.
org.restlet.ext.websocket/​src/​test/​java/​org/​restlet/​ext/​websocket/​WebSocketSessionTestCase.java	Migrates client usage and adds settings and lifecycle assertions.
org.restlet.ext.websocket/​src/​test/​java/​org/​restlet/​ext/​websocket/​WebSocketCompressionTestCase.java	Migrates compression and frame-limit tests to setters.
org.restlet.ext.websocket/​src/​main/​java/​org/​restlet/​ext/​websocket/​WebSocketClient.java	Replaces the builder with configurable, restartable client lifecycle methods.

_{Review effort: Balanced}

[sonarqubecloud]

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud