Skip to content

Netty client: honor https.proxyHost / https.proxyPort system properties for HTTPS requests #1570

Closed

Description

@jlouvel

Problem

NettyClientHelper.getProxyHost() / getProxyPort() fall back only to the http.proxyHost / http.proxyPort system properties, for both HTTP and HTTPS requests. The JDK convention (see Networking Properties) uses https.proxyHost / https.proxyPort for HTTPS. Users with only the https.* properties set get no proxy, and users with only the http.* properties set send HTTPS through a proxy they may not have meant for it.

Proposed fix

  • Choose the system properties by scheme: https.proxyHost / https.proxyPort (default 443 per the JDK, or keep 3128) for HTTPS, http.* for HTTP.
  • Keep the proxyHost / proxyPort connector parameters for both schemes, and possibly add httpsProxyHost / httpsProxyPort parameters.
  • Make the pool and target computation (forwardProxy in create(), acquire()) use the proxy for the request's scheme.
  • Update the Javadoc parameter table and add tests.

Activity

  1. added 4 commits that reference this issue on Oct 30, 2026
    c1cfb97
    8c343f5
    825939b
    d987b04
  2. jlouvel commented on Nov 5, 2026

    @jlouvel
    CollaboratorAuthor

    Fixed by #1575: HTTPS requests use the https.proxyHost / https.proxyPort system properties, HTTP requests the http.* ones; the proxyHost / proxyPort parameters still apply to both. No separate httpsProxyHost parameter was added. #1577 also honors nonProxyHosts.

    🤖 Generated with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions