Uplink popover absorbs the bus-link row; sidebar top-group + pinned settings - #9
Merged
Merged
Conversation
- A hardcoded 20°C presented a fabricated reading as real data when temperature was unknown; the placeholder now reads as missing data.
…ass portal fix - UplinkStatusButton popover gains the Hub (bus-link) dot row next to Tailscale; RouterStatusIcon + its glyphs delete (CONTEXT.md updated). - Popover portals into App's themed root (portalContainer) so bg-card/ backdrop-blur resolve per theme — same fix the Sheet drawer uses; popover rendered light in dark theme when portaled to document.body. - Network settings footer deep-links to the Settings network group (settingsFocus), useNow tick, formatBytes + PLMN headline libs.
…ale doc ref - BUS_TONE (bus-link dot colour) duplicated in UplinkStatusButton and SettingsTab; extracted to lib/connection.ts alongside busStatusText. - UplinkStatusButton popover's 'Network settings' CTA now uses focusView/onFocusConsumed so a repeat tap (same value after App clears the target) still re-triggers the jump to the Network subpage. - DisplaySleepButton doc comment still referenced the deleted RouterStatusIcon; updated to 'decorative glyph'. - Added regression test for focus-consumption callback flow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Header shrinks to one status control: the bus-link icon is gone, its state lives on as a dot row inside the uplink popover.
Evidence
document.body(outside the.darkroot) —bg-card/40resolved against light:roottokens, so the popup rendered white in dark theme.After: computed styles in-browser, dark theme — popover
oklab(0.216167 -0.00757139 -0.034705 / 0.4)+blur(12px)+ white/10 border, byte-identical to the Sheet drawer's popup; light theme resolves white/40 symmetrically.8,8,8,8px; settings 236 px below the group, 9 px from the pill's bottom edge; accent indicator aligns exactly (44×44) on the settings tab after the restructure.pnpm typecheckclean; vitest 151/151 (incl. reworkedUplinkStatusButtonpopover suites).Merge Danger
Door: two-way
Blast Radius: header + settings surfaces. The popover's theme fix rides App's shared
portalContainer(same node the Sheet uses);UplinkStatusButton's new requiredportalContainerprop is threaded App → component. No wire-contract changes — MQTT topics untouched.