Skip to content

Device apps (portal): a setting its administrator holds is said so; a udp service is a connection alone - #1341

Merged
evanrbowers merged 1 commit into
apps-contract-1from
ac1/admin-lock-udp
Nov 17, 2026
Merged

evanrbowers merged 1 commit into
apps-contract-1from
ac1/admin-lock-udp

Conversation

@evanrbowers

Copy link
Copy Markdown
Contributor

Evan's D6, D2 and D8 for apps-contract-1, in the portal's device apps (built in #1340).

D6 — a setting the device's administrator holds. graphql's DeviceAppSetting.control (apps-contract-1 device-apps-resolver.ts): cloud+local (the default), local, cloud, or a hold — off, on where the release says forcible, or a choice it fixes. The device applies the held value and graphql refuses an owner's change (policyRefusalOf). A held setting is now:

  • shown at the held value, greyed, "Set by this device's administrator" — for a switch, a choice and a field alike (appSettingNote, adminHolds);
  • with its product's lock beside it where the product holds it too ("Set by this device's administrator · Managed by product Kiosks (enforced)");
  • offered no change: the switch, select, field and Clear are disabled (settingLocked, as before).

local keeps "Set only on the device"; a product's lock alone keeps its own words. Pinned for the console's "Allow AI commands" (ai_commands, forcible) held off and held on in DeviceAppSetting.test.tsx. DeviceSettingChoice takes the caller's why so an app setting says it in the app's words; device settings are unchanged.

D2 — udp. AppProtocol adds udp. A udp service has nothing to launch and never a terminal or a page: its Open is Connect, which goes to the service's connection with autoConnect and no autoLaunch; its service line says UDP port, the port for the person's own UDP client; its icon is the generic one. opensTerminal stays ssh-only (pinned for udp with person-certificates).

D8 — console port. Nothing in the portal assumes 22 for the console: the terminal takes the app's service's port (AppTerminal servicePort). The || 22 defaults left (ServiceConnectButton, TerminalPage, sshCommand) are ssh's own default for a generic ssh service with no port, not the console's.

Gates: npm run typecheck clean; vitest run 217 files, 2148 tests pass; npm run i18n:extract -w=frontend with the catalogs committed (three new keys), npm run i18n:check passes.

🤖 Generated with Claude Code

… udp service is a connection alone

A setting the device's administrator holds (DeviceAppSetting.control off, on —
where its release says forcible, as the console's "Allow AI commands" — or a choice
it fixes) is shown at the held value, greyed, "Set by this device's administrator",
with its product's lock beside it where the product holds it too. graphql refuses a
change to it, so none is offered.

A service whose protocol is udp has nothing to launch and no terminal or page: its
Open is Connect, which connects without launching, and its line says UDP port, the
port for the person's own UDP client.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@evanrbowers

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T03:14:58.255073Z 5c78f17 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: 5c78f17a6d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@evanrbowers
evanrbowers merged commit bd1087d into apps-contract-1 Nov 17, 2026
1 of 2 checks passed
@evanrbowers
evanrbowers deleted the ac1/admin-lock-udp branch November 17, 2026 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant