Repository navigation
Device apps (portal): a setting its administrator holds is said so; a udp service is a connection alone - #1341
Merged
Merged
Conversation
… udp service is a connection alone A setting the device's administrator holds (DeviceAppSetting.control off, on — where its release says forcible, as the console's "Allow AI commands" — or a choice it fixes) is shown at the held value, greyed, "Set by this device's administrator", with its product's lock beside it where the product holds it too. graphql refuses a change to it, so none is offered. A service whose protocol is udp has nothing to launch and no terminal or page: its Open is Connect, which connects without launching, and its line says UDP port, the port for the person's own UDP client. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Contributor
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Evan's D6, D2 and D8 for apps-contract-1, in the portal's device apps (built in #1340).
D6 — a setting the device's administrator holds. graphql's
DeviceAppSetting.control(apps-contract-1device-apps-resolver.ts):cloud+local(the default),local,cloud, or a hold —off,onwhere the release saysforcible, or a choice it fixes. The device applies the held value and graphql refuses an owner's change (policyRefusalOf). A held setting is now:appSettingNote,adminHolds);settingLocked, as before).localkeeps "Set only on the device"; a product's lock alone keeps its own words. Pinned for the console's "Allow AI commands" (ai_commands, forcible) held off and held on inDeviceAppSetting.test.tsx.DeviceSettingChoicetakes the caller'swhyso an app setting says it in the app's words; device settings are unchanged.D2 —
udp.AppProtocoladdsudp. A udp service has nothing to launch and never a terminal or a page: its Open is Connect, which goes to the service's connection withautoConnectand noautoLaunch; its service line says UDP port, the port for the person's own UDP client; its icon is the generic one.opensTerminalstays ssh-only (pinned for udp withperson-certificates).D8 — console port. Nothing in the portal assumes 22 for the console: the terminal takes the app's service's port (
AppTerminalservicePort). The|| 22defaults left (ServiceConnectButton,TerminalPage,sshCommand) are ssh's own default for a generic ssh service with no port, not the console's.Gates:
npm run typecheckclean;vitest run217 files, 2148 tests pass;npm run i18n:extract -w=frontendwith the catalogs committed (three new keys),npm run i18n:checkpasses.🤖 Generated with Claude Code