refactor(notary): separate migration coverage artifacts#485
Merged
Conversation
Signed-off-by: Jeremi Joslin <[email protected]>
jeremi
marked this pull request as ready for review
July 25, 2026 13:29
jeremi
marked this pull request as draft
July 25, 2026 13:33
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cc6184c8e7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jeremi
marked this pull request as ready for review
July 25, 2026 13:58
jeremi
enabled auto-merge (squash)
July 25, 2026 14:02
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
state_plane/migration.rs, while moving the byte-identical v1 schema into a compile-time included.sqlfilestate_plane/migration/tests.rswithout changing its module path or test entry points, and update the unsafe-code inventory referencescargo-llvm-cov0.8.7, print the coverage summary, and upload an LCOV artifact per PostgreSQL versionWhy
The previous 5,133-line Rust file combined production code, 1,727 lines of embedded SQL, and about 2,500 lines of tests that are intentionally ignored outside dedicated PostgreSQL conformance. Generic Rust coverage therefore made the active migration look almost entirely untested without showing the coverage produced by the conformance workflow.
This keeps the migration in place because it remains the production schema installer and runtime attestation contract. It makes the source layout and coverage results reflect that responsibility more accurately.
Verification
cargo test --locked -p registry-notary-server --lib: 446 passed, 6 ignored, 0 failedregistry-notary-server71.02% lines; productionmigration.rs5.26% linesmigration.rs94.90% lines and 95.00% functionsjust ci-preflightcargo fmt --all -- --checkcargo clippy --locked -p registry-notary-server -p registry-notary --all-targets -- -D warningsactionlint .github/workflows/notary-postgres-conformance.ymlgit diff --check