Repository navigation
fix(ios): checks drop the CocoaPods lint steps - #355
Merged
Merged
Conversation
pod spec lint validated the podspec against the tag of the version already released, not the change under review, and pod lib lint built the same podspec the demo app build above already builds. The token they used becomes optional until callers stop passing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The iOS checks drop
pod spec lintandpod lib lint.pod spec lintvalidated the podspec against the tag of the version already released, not the change under review.pod lib lintbuilt the same podspec the demo app build already builds.cocoapodsTokenis optional now, so callers that still pass it keep working; it goes once they stop.