Repository navigation
feat(core): the new core is the bridges' only: apps no longer pick it through Rees46Config, Flutter and React Native start it with Rees46.initializeBridge - #237
Merged
Conversation
… through Rees46Config, Flutter and React Native start it with Rees46.initializeBridge Rees46Config no longer takes coreV2 in its public init, and the property is internal: a configuration an app makes runs the old core. The bridges call Rees46.initializeBridge(_:segment:completion:) behind @_spi(Bridge), which is Rees46.initialize on the new core. The core is still decided once per process by its first initialization, and core_flag_mismatch says so. segment is the A/B group a bridge kept in its own storage. The device takes it only while it has no group of its own, in the device's store or in the shop's partition, and only A or B; otherwise invalid_config says segment_kept or segment_invalid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apps can no longer pick the new core:
Rees46ConfiglosescoreV2from its public init (code that passes it stops compiling), soRees46.initializeandregisterrun the old core.Bridges start a shop on the new core with
Rees46.initializeBridge(config, segment:, completion:)behind@_spi(Bridge), the same name as on Android.segmentis the A/B group the bridge kept from its own storage. The device takes it only while it has no group of its own, and onlyAorB; otherwise the log saysinvalid_configwithsegment_keptorsegment_invalid.The core is still decided once per process by the first initialization.