Skip to content

fix(sdk): request callbacks, timeouts and logs without user data (DEV-4719) - #234

Merged
Xyzcancer merged 7 commits into
masterfrom
fix/DEV-4719-android-audit
Nov 12, 2026
Merged

Xyzcancer merged 7 commits into
masterfrom
fix/DEV-4719-android-audit

Conversation

@Xyzcancer

Copy link
Copy Markdown
Contributor

Fixes from the SDK audit (DEV-4719):

  • Any 2xx answer reaches onSuccess. Other codes, 3xx included, reach onError with their status.
  • A request ends in one onSuccess or onError. If onSuccess throws (the SDK's own parsing included), one onError(-1) follows. A callback that throws no longer crashes the app.
  • 5 s connect and 10 s read timeouts. An answer cut off by the timeout ends in onError.
  • A clicked push no longer overwrites the code of story and push events.
  • Instant search sends excluded_merchants without locations too.
  • Logs carry the method and path only: no request data, error bodies, push payloads, advertising id or /init answer. The same goes for the v3 stories, polls and popups client.
  • androidx.test libraries move to test configurations and no longer reach the app's release build.

…tly one callback; a callback of the app that throws no longer crashes it; a silent server ends in onError after 10 s; a clicked push keeps off the code of story and push events; requests are logged by method and path, without the user's data
… onSuccess that fails ends in one onError(-1), so a parse error inside the SDK still reaches the app; error answers are logged without their body
@Xyzcancer
Xyzcancer merged commit d438357 into master Nov 12, 2026
1 check passed
@Xyzcancer
Xyzcancer deleted the fix/DEV-4719-android-audit branch November 12, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant