Repository navigation
Fix weakMapMemoize maxSize counting argument nodes instead of results - #830
Closed
Narek-Khachikyan wants to merge 1 commit into
Closed
Narek-Khachikyan wants to merge 1 commit into
Narek-Khachikyan wants to merge 1 commit into
Conversation
✅ Deploy Preview for reselect-docs canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
weakMapMemoizecounts new primitive argument nodes towardmaxSize, so cycling two argument pairs withmaxSize: 2computes six times.Fixes #829.
Evidence
Proof: all four new regressions fail before the fix and pass after it, with two pairs computing twice.
pnpm testpasses 141 runtime and 29 type tests; lint, formatting, package build, and package type validation pass.Merge danger
Two-way door. The change affects generation accounting when
maxSizeis set.