Repository navigation
Conversation
✅ Deploy Preview for reselect-docs canceled.
|
Contributor
|
did you encounter this issue in a real app? |
Contributor
|
I don't think we need to handle this case. We expect to deal with plain data, no proto shenanigans. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createStructuredSelectordrops an own computed__proto__key instead of returning the same keys as its input selectors object. An object or null result also changes the output object's prototype.The result reducer assigns each key into
{}, so this key invokes the inherited setter. Define it as an enumerable, writable, configurable own property while keeping ordinary assignment for other keys and preserving the plain-object result.Reproduction on 5.3.0:
Before:
[]. After:['__proto__'], with an own property value of17.