fix(mcp): select a rustls crypto provider - #1127
Open
hippiuS wants to merge 1 commit into
Open
Conversation
hippiuS
marked this pull request as ready for review
September 3, 2026 21:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aws-lc-rsrustlsCryptoProviderbefore the MCP server creates TLS clientsredis_typeis registered, and exercises a realrediss://tool callWhy
The default
redisctl-mcpfeature graph enables two rustls providers: reqwest 0.13 bringsaws-lc-rs, while the Redis client bringsring. Rustls 0.23 cannot choose between them automatically, so the first Redis TLS data-plane call panics with:The server initializes and lists tools successfully before that point, which makes the failure appear command-specific even though any Redis command over TLS can trigger it.
Compatibility
This is a safety correction. It does not add, remove, or rename MCP tools, change their schemas, or alter CLI output/contracts. The catalog baseline is unchanged.
Tests
redis_type, then the TLS tool call reproduces the CryptoProvider panicisError: trueconnection failure and the process exits cleanlycargo fmt --all -- --checkcargo clippy -p redisctl-mcp --all-targets --all-features -- -D warningscargo test -p redisctl-mcp --test tls_crypto_provider --all-features -- --nocapturecargo test -p redisctl-mcp --all-features catalog_contract::mcp_catalog_matches_1_0_baselineThe repository workflows were created with
action_requiredbecause this is a first-time fork contribution. A maintainer needs to approve them before the full workspace CI gate can run.