feat(init): install the official Redis skills with lock-aware reporting - #1102
Open
VaskoAtanasovRedis wants to merge 3 commits into
Open
feat(init): install the official Redis skills with lock-aware reporting#1102VaskoAtanasovRedis wants to merge 3 commits into
VaskoAtanasovRedis wants to merge 3 commits into
Conversation
VaskoAtanasovRedis
force-pushed
the
feat/init/5-skills-install
branch
from
August 13, 2026 08:16
334f71b to
4ffa607
Compare
VaskoAtanasovRedis
force-pushed
the
feat/init/5-skills-install
branch
from
August 13, 2026 08:20
4ffa607 to
9c29803
Compare
VaskoAtanasovRedis
force-pushed
the
feat/init/5-skills-install
branch
from
August 13, 2026 11:37
9c29803 to
3066d19
Compare
VaskoAtanasovRedis
force-pushed
the
feat/init/5-skills-install
branch
from
August 13, 2026 13:14
3066d19 to
478ff14
Compare
The standard skills CLI (npx skills add redis/agent-skills) is the primary path, with statuses diffed from the skills-lock.json it owns; unmanaged skill dirs are surfaced and their fate reported from disk truth. An explicit --skills-repo / REDISCTL_INIT_SKILLS_REPO checkout is copied directly, and --skills-global installs for the user. With neither npx nor a checkout the step is skipped with the remedy in the note - skills are additive, so the onboarding still stands (the PoC's clone-cache fallback is deliberately not ported). Two adjacent fixes surfaced by this slice's testing: the free-port probe now checks loopback and both wildcard families (Docker publishes ports on a dual-stack [::] listener the old IPv4 probe missed), and project-mutating commands run in the plan's cwd instead of the process cwd (sh_in), which the future MCP consumer depends on.
A solo-Claude checkout copy lands in .claude/skills but was reported as .agents/skills, and unmanaged-collision detection scanned only the shared layout - a skill the installer left in place could read as updated. Subjects now come from the actual destination, collisions scan both layouts, and disk truth is read from the probed path. Also in this slice's scope: a dry run with --skills-repo names the checkout instead of pretending to npx (fix(init): dry-run skills checkout instead of pretending to npx).
VaskoAtanasovRedis
force-pushed
the
feat/init/5-skills-install
branch
from
August 14, 2026 09:16
478ff14 to
d448666
Compare
VaskoAtanasovRedis
marked this pull request as ready for review
August 18, 2026 13:34
…error A stale npx cache can run an old skills CLI, and any failure was reported as a generic '(offline?)' guess that hides the real cause. Pin skills@latest so npx always resolves the current CLI, and lead the skipped note with the installer's own first error line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1101. The official redis/agent-skills install with the PoC's lock semantics.
npx -y skills add redis/agent-skillsin the project directory; statuses are diffed from the CLI's ownskills-lock.json(created / unchanged / updated). Verified live against all 8 official skills.--skills-globalreads names only from the user lock (its hash schema churns).--skills-repo/$REDISCTL_INIT_SKILLS_REPOcopies from a local checkout - offline-safe, and the seam that keeps the test suite hermetic. No npx and no checkout →skippedwith the remedy.Tests: hermetic via the fixture checkout; one
#[ignore]test codifies the real npx path.Verify: run init twice in a scratch dir with a dead
--url; first run installs 8 skills + lock, second reads all unchanged.Testing
Init run
Re-run
Update: the skills CLI is now invoked as
skills@latest(a stale npx cache could run an old CLI), and a failed install reports the installer's own error line instead of a generic "(offline?)" guess.