Skip to content

RHIDP-15776: Align inherit matching with the operator - #4808

Open
subhashkhileri wants to merge 2 commits into
redhat-developer:mainfrom
subhashkhileri:rhidp-15776-operator-aligned-inherit
Open

subhashkhileri wants to merge 2 commits into
redhat-developer:mainfrom
subhashkhileri:rhidp-15776-operator-aligned-inherit

Conversation

@subhashkhileri

Copy link
Copy Markdown
Member

Summary

  • resolve {{inherit}} against included plugins by the final OCI image name, ignoring registry host and namespace
  • replace the reference with the included concrete package before existing enable/disable and merge processing
  • preserve ordinary OCI identity and explicit !plugin-path behavior; path removal remains scoped to RHIDP-16807
  • reject ambiguous same-level image-name collisions with an error naming both entries
  • keep disabled catalog entries available when a higher-precedence cross-registry inherit entry re-enables them

Why

The operator uses the final name only for reference lookup, then continues normal merging with the resolved concrete package. This fixes cross-registry inheritance without changing unrelated OCI merge behavior or prematurely removing explicit plugin paths.

Jira: https://redhat.atlassian.net/browse/RHIDP-15776

Validation

  • CI=true yarn test --runInBand — 20 suites, 256 tests passed
  • yarn tsc
  • yarn lint:all
  • yarn prettier:check
  • package build
  • yarn build:api-reports:only --ci

@subhashkhileri
subhashkhileri requested review from a team as code owners September 16, 2026 12:22
@rhdh-gh-app

rhdh-gh-app Bot commented Sep 16, 2026

Copy link
Copy Markdown

Important

This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior.

Changed Packages

Package Name Package Path Changeset Bump Current Version
@red-hat-developer-hub/cli-module-install-dynamic-plugins workspaces/install-dynamic-plugins/packages/install-dynamic-plugins minor v0.5.0

@codecov

codecov Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.06931% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.28%. Comparing base (d477924) to head (30dbd15).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4808      +/-   ##
==========================================
+ Coverage   63.26%   63.28%   +0.01%     
==========================================
  Files        2675     2675              
  Lines      106439   106507      +68     
  Branches    29767    29787      +20     
==========================================
+ Hits        67340    67400      +60     
- Misses      37320    37328       +8     
  Partials     1779     1779              
Flag Coverage Δ *Carryforward flag
adoption-insights 84.77% <ø> (ø) Carriedforward from 1e1c39a
ai-integrations 78.80% <ø> (ø) Carriedforward from 1e1c39a
app-defaults 54.82% <ø> (ø) Carriedforward from 1e1c39a
augment 46.67% <ø> (ø) Carriedforward from 1e1c39a
boost 84.97% <ø> (ø) Carriedforward from 1e1c39a
bulk-import 73.12% <ø> (ø) Carriedforward from 1e1c39a
cost-management 13.53% <ø> (ø) Carriedforward from 1e1c39a
dcm 73.47% <ø> (ø) Carriedforward from 1e1c39a
e2e-adoption-insights 60.00% <ø> (ø) Carriedforward from 1e1c39a
e2e-extensions 62.31% <ø> (ø) Carriedforward from 1e1c39a
e2e-global-header 49.71% <ø> (ø) Carriedforward from 1e1c39a
e2e-homepage 61.11% <ø> (ø) Carriedforward from 1e1c39a
e2e-intelligent-assistant 46.01% <ø> (ø) Carriedforward from 1e1c39a
e2e-orchestrator 49.49% <ø> (ø) Carriedforward from 1e1c39a
e2e-orchestrator-plugin 49.48% <ø> (ø) Carriedforward from 1e1c39a
e2e-quickstart 55.21% <ø> (ø) Carriedforward from 1e1c39a
e2e-scorecard 50.05% <ø> (ø) Carriedforward from 1e1c39a
e2e-theme 16.36% <ø> (ø) Carriedforward from 1e1c39a
extensions 58.30% <ø> (ø) Carriedforward from 1e1c39a
global-floating-action-button 71.18% <ø> (ø) Carriedforward from 1e1c39a
global-header 67.88% <ø> (ø) Carriedforward from 1e1c39a
homepage 48.39% <ø> (ø) Carriedforward from 1e1c39a
install-dynamic-plugins 72.57% <93.06%> (+0.80%) ⬆️
intelligent-assistant 77.99% <ø> (ø) Carriedforward from 1e1c39a
konflux 91.98% <ø> (ø) Carriedforward from 1e1c39a
lightspeed 69.02% <ø> (ø) Carriedforward from 1e1c39a
mcp-integrations 84.46% <ø> (ø) Carriedforward from 1e1c39a
orchestrator 77.32% <ø> (ø) Carriedforward from 1e1c39a
quickstart 63.74% <ø> (ø) Carriedforward from 1e1c39a
sandbox 79.56% <ø> (ø) Carriedforward from 1e1c39a
scorecard 88.48% <ø> (ø) Carriedforward from 1e1c39a
theme 87.91% <ø> (ø) Carriedforward from 1e1c39a
translations 5.12% <ø> (ø) Carriedforward from 1e1c39a
x2a 78.44% <ø> (ø) Carriedforward from 1e1c39a

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d477924...30dbd15. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@subhashkhileri

Copy link
Copy Markdown
Member Author

/fs-review

@fullsend-ai-review

fullsend-ai-review Bot commented Sep 16, 2026

Copy link
Copy Markdown

🤖 Finished Review · ❌ Failure (agent timed out after 20m0s without completing (timeout: 20m0s)) · Started 12:42 PM UTC · Completed 1:04 PM UTC

Commit: 1e1c39a · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6

@sonarqubecloud

Copy link
Copy Markdown

@subhashkhileri

Copy link
Copy Markdown
Member Author

/fs-review

@fullsend-ai-review

fullsend-ai-review Bot commented Sep 16, 2026

Copy link
Copy Markdown

🤖 Finished Review · ❌ Failure (agent timed out after 20m0s without completing (timeout: 20m0s)) · Started 2:53 PM UTC · Completed 3:16 PM UTC

Commit: 30dbd15 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant