Conversation
jonkoops
requested review from
a team,
ciiay and
divyanshiGupta
as code owners
September 16, 2026 11:08
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
jonkoops
force-pushed
the
remove-global-header-legacy
branch
from
September 16, 2026 11:18
68a8b4d to
14aba83
Compare
jonkoops
commented
Sep 16, 2026
| @@ -11,136 +11,3 @@ dynamicPlugins: | |||
| # config: | |||
Contributor
Author
There was a problem hiding this comment.
I left this NFS config commented out deliberately; please let me know if this needs to be enabled now that the legacy config has been removed.
Contributor
Author
|
Not sure if a changeset is needed here; I can add one, which would likely be a major version bump (I presume). |
jonkoops
force-pushed
the
remove-global-header-legacy
branch
2 times, most recently
from
September 16, 2026 11:53
00ef583 to
b42c4ad
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4804 +/- ##
==========================================
- Coverage 63.65% 63.59% -0.06%
==========================================
Files 2692 2689 -3
Lines 107325 107145 -180
Branches 30062 30047 -15
==========================================
- Hits 68318 68142 -176
+ Misses 37236 37209 -27
- Partials 1771 1794 +23
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Delete the app-legacy dev shell, plugin legacy exports, and Scalprum hooks. Make Playwright and workspace scripts NFS-only. Keep NFS app.extensions guidance commented in app-config.dynamic.yaml. Add @axe-core/playwright to the workspace root for e2e a11y tests. Ref: RHIDP-15353 Signed-off-by: Jon Koops <[email protected]> Signed-off-by: Christoph Jerolimov <[email protected]>
christoph-jerolimov
force-pushed
the
remove-global-header-legacy
branch
from
September 18, 2026 14:12
b42c4ad to
6b55b6d
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the global-header legacy dev shell, OFS plugin source, and Scalprum dependencies. E2E and workspace scripts use the NFS app only.
RHIDP-15353