Conversation
ciiay
requested review from
a team,
divyanshiGupta and
logonoff
as code owners
August 20, 2026 02:42
Changed Packages
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4405 +/- ##
=======================================
Coverage 63.60% 63.60%
=======================================
Files 2685 2686 +1
Lines 107077 107104 +27
Branches 30010 30013 +3
=======================================
+ Hits 68101 68127 +26
- Misses 37165 37166 +1
Partials 1811 1811
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Member
Author
|
RHDHBUGS-3603 (Inspect Entity covered by the masthead) was split out of this PR. That overlay/z-index issue is independent of the page-shell HeaderTabs fix here. |
ciiay
force-pushed
the
fix/RHDHBUGS-3627-masthead-sidebar-offset
branch
2 times, most recently
from
September 1, 2026 13:46
851e820 to
2283811
Compare
gustavolira
pushed a commit
to redhat-developer/rhdh-plugin-export-overlays
that referenced
this pull request
Sep 1, 2026
…GS-3627
The suite's remaining failure is not a test problem. The global header is a
sticky MuiAppBar with z-index 1100 and the sidebar list starts at the top of the
viewport, so its first item — Catalog — renders underneath it. Playwright
retried the click for 10 seconds, 21 attempts, each reporting the element
visible, enabled, stable and scrolled into view, then blocked by
`<nav id="global-header">`. The screenshot confirms it: the first visible
sidebar entry is Create, and Catalog is nowhere on screen while the
accessibility tree has it as the first sidebar child. A user with a mouse cannot
open Catalog either.
That is RHDHBUGS-3627, which absorbed RHDHBUGS-3573 ("Global header overlaps top
content of sidebar navigation") — the exact symptom here. The video, screenshots
and an offline reproduction recipe are attached to that ticket. Its fix,
redhat-developer/rhdh-plugins#4405, is still open, so no image the e2e lanes
pull carries it yet.
`test.fail`, not `test.skip`, and that is the point of this commit rather than
an implementation detail. This PR exists because a skip went stale: it cited
RHIDP-15482, the ticket closed, nobody re-read the test, and the workspace sat
with no nightly coverage for months. Replacing one skip with another would
rebuild the same debt against a different ticket.
`fail` does not have that failure mode. Verified against the runner this repo
pins (@playwright/test 1.59.1) rather than assumed:
- while the bug exists: the test reports ✘ but the run is green, and the
other two tests keep running — so nightly coverage is restored for them.
- once the bug is fixed: "Expected to fail, but passed." → the run goes red
until someone deletes the marker.
CI becomes the reminder instead of a person. Applied unconditionally rather than
gated on E2E_NIGHTLY_MODE, because the overlap breaks the PR check too.
Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
Contributor
|
Tested it in rhdh-local, found some issues Screen.Recording.2026-09-02.at.3.34.41.PM.mov |
Member
Author
|
@rohitratannagar Thanks for testing this. The recording looks like rhdh-local / OFS. This change is aimed at NFS (app-next) — OFS is being deprecated in the upcoming release, so the page-shell contract we need to preserve is NFS. Could you re-test on NFS / app-next with this PR’s theme + global-header overlays, especially:
The RHDH-theme well sitting against the sidebar is existing PF6 page-inset behavior ( |
gustavolira
added a commit
to redhat-developer/rhdh-plugin-export-overlays
that referenced
this pull request
Sep 10, 2026
…GS-3627
The suite's remaining failure is not a test problem. The global header is a
sticky MuiAppBar with z-index 1100 and the sidebar list starts at the top of the
viewport, so its first item — Catalog — renders underneath it. Playwright
retried the click for 10 seconds, 21 attempts, each reporting the element
visible, enabled, stable and scrolled into view, then blocked by
`<nav id="global-header">`. The screenshot confirms it: the first visible
sidebar entry is Create, and Catalog is nowhere on screen while the
accessibility tree has it as the first sidebar child. A user with a mouse cannot
open Catalog either.
That is RHDHBUGS-3627, which absorbed RHDHBUGS-3573 ("Global header overlaps top
content of sidebar navigation") — the exact symptom here. The video, screenshots
and an offline reproduction recipe are attached to that ticket. Its fix,
redhat-developer/rhdh-plugins#4405, is still open, so no image the e2e lanes
pull carries it yet.
`test.fail`, not `test.skip`, and that is the point of this commit rather than
an implementation detail. This PR exists because a skip went stale: it cited
RHIDP-15482, the ticket closed, nobody re-read the test, and the workspace sat
with no nightly coverage for months. Replacing one skip with another would
rebuild the same debt against a different ticket.
`fail` does not have that failure mode. Verified against the runner this repo
pins (@playwright/test 1.59.1) rather than assumed:
- while the bug exists: the test reports ✘ but the run is green, and the
other two tests keep running — so nightly coverage is restored for them.
- once the bug is fixed: "Expected to fail, but passed." → the run goes red
until someone deletes the marker.
CI becomes the reminder instead of a person. Applied unconditionally rather than
gated on E2E_NIGHTLY_MODE, because the overlap breaks the PR check too.
Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
gustavolira
added a commit
to redhat-developer/rhdh-plugin-export-overlays
that referenced
this pull request
Sep 10, 2026
…GS-3627
The suite's remaining failure is not a test problem. The global header is a
sticky MuiAppBar with z-index 1100 and the sidebar list starts at the top of the
viewport, so its first item — Catalog — renders underneath it. Playwright
retried the click for 10 seconds, 21 attempts, each reporting the element
visible, enabled, stable and scrolled into view, then blocked by
`<nav id="global-header">`. The screenshot confirms it: the first visible
sidebar entry is Create, and Catalog is nowhere on screen while the
accessibility tree has it as the first sidebar child. A user with a mouse cannot
open Catalog either.
That is RHDHBUGS-3627, which absorbed RHDHBUGS-3573 ("Global header overlaps top
content of sidebar navigation") — the exact symptom here. The video, screenshots
and an offline reproduction recipe are attached to that ticket. Its fix,
redhat-developer/rhdh-plugins#4405, is still open, so no image the e2e lanes
pull carries it yet.
`test.fail`, not `test.skip`, and that is the point of this commit rather than
an implementation detail. This PR exists because a skip went stale: it cited
RHIDP-15482, the ticket closed, nobody re-read the test, and the workspace sat
with no nightly coverage for months. Replacing one skip with another would
rebuild the same debt against a different ticket.
`fail` does not have that failure mode. Verified against the runner this repo
pins (@playwright/test 1.59.1) rather than assumed:
- while the bug exists: the test reports ✘ but the run is green, and the
other two tests keep running — so nightly coverage is restored for them.
- once the bug is fixed: "Expected to fail, but passed." → the run goes red
until someone deletes the marker.
CI becomes the reminder instead of a person. Applied unconditionally rather than
gated on E2E_NIGHTLY_MODE, because the overlap breaks the PR check too.
Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
Contributor
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
Fixes: https://redhat.atlassian.net/browse/RHDHBUGS-3627 Signed-off-by: Yi Cai <[email protected]> Co-authored-by: Cursor <[email protected]>
Cancelling the top inset under the global header still subtracted two insets from the content well, which left an extra gray band at the bottom of NFS pages. Co-authored-by: Cursor <[email protected]>
Co-authored-by: Cursor <[email protected]>
ciiay
force-pushed
the
fix/RHDHBUGS-3627-masthead-sidebar-offset
branch
from
September 18, 2026 03:53
96eac59 to
6295b02
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
NFS never reserved masthead height, so theme
100vhpage-shell rules and the fixed sidebar sat under the global header and clipped HeaderTabs (RHDHBUGS-3627). This change publishes--rhdh-global-header-heightfrom the header layout, subtracts it from theme viewport sizing, and offsetsBackstageSidebar-drawerso tabs and sidebar content sit fully below the masthead.The NFS demo app now matches OFS: branding stays in the header, not a duplicate sidebar logo.
Inspect Entity being covered by the masthead is a separate overlay/z-index issue and is tracked in RHDHBUGS-3603.
Fixed
Checklist
rhdhbugs_3627.mp4
screen recording on app-next:
rhdhbugs_3627.mp4