Repository navigation
refactor!: rename the ctype_id slice column to content_section_id - #6786
Merged
Merged
Conversation
Aligns the column of `rex_article_slice` and `rex_article_slice_history` with the content section terminology (`ArticleSlice::$contentSectionId`). Existing 6.x dev databases have to rename the column manually.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the
ctype_idcolumn ofrex_article_sliceandrex_article_slice_historytocontent_section_id, in line with the content section terminology of 6.x (ArticleSlice::$contentSectionId,ContentSection). The full name is used rather thansection_idbecause "section" is already taken by the backend panel (core/page/section.php), and the neighbouring columns are spelled out as well (article_id,language_id).There is no migration —
install()only describes the target state. Existing 6.x dev databases have to rename the column manually, otherwiseinstall()adds the new column next to the old NOT NULLctype_idand inserting slices fails:The remaining
ctypenaming in PHP (StructureContext::$ctypeId,ArticleSlice::getFirstSliceForCtype(), thectyperequest parameter, extension point params) follows in a separate PR.