Repository navigation
refactor!: make the form widgets, FieldRow and FieldGroup final - #6761
Merged
Merged
Conversation
Their markup is customized by overriding their views via ViewResolver, which works for final classes as well; subclasses would turn every change of their properties into a breaking change. The list helpers of Field are final as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #6754.
Input,Textarea,SelectInput,ChoiceList,CheckboxInput,ArticleInput,ArticleListInput,MediaInput,MediaListInput),FieldRowandFieldGroupare final now. Their markup is customized by overriding their views viaViewResolver, which works for final classes as well; subclasses would turn every change of their properties and constructors into a breaking change.Field::scalarToRaw()andField::splitList()are final, they are helpers for field types, not meant to be overridden.ArticleInput::labelTarget()returnsstring, as its id is required.The field types themselves stay open for extension (
EmailandUrlextendText, addons may add their own variants).