Repository navigation
release-copilot: wait for the Hermes run to appear, make the next bump required - #1507
Merged
Merged
Conversation
On 260318099.0.7 the wait step asked for the run a second after the dispatch, before GitHub listed it, found nothing and stopped the phase while the run was building. It now looks for up to five minutes.
Declining it used to skip it, which is how a release gets finished with its branch still naming the version just published. Declining now stops the run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Two fixes from cutting Hermes
260318099.0.7for 0.89.0-rc.1.Tested
220 unit tests and 23/23 evals. The rest of the
.0.7phase (wait, verify, pin, push, next bump in meta/hermes#2306) then ran with these scripts.