Skip to content

[0.89] Fix addViewAt crash for views held by startViewTransition on Android #1504

Closed

Description

@pawicao

Target Branch

0.89

Link to commit or PR to be picked

react/react-native@45152f1

Description

This fixes a crash on Android. PR: react/react-native#59776

When a parent holds a child with ViewGroup.startViewTransition, the child keeps its parent after Fabric removes it. If the next mutation inserts that view into a different parent, SurfaceMountingManager.addViewAt throws addViewAt: failed to insert view ... into parent, and the app crashes. The existing recovery cannot release the view. It also marks the tag, so a later Remove of the view is skipped.

React Native Screens holds the content of a removed screen in this way. Any library that moves a view out of such a screen crashes. For example, Reanimated shared element transitions crash on back navigation (software-mansion/react-native-reanimated#11054). Without this fix in a release, libraries must add their own workarounds (software-mansion/react-native-reanimated#11101).

The change is small and has low risk:

  • It changes 5 lines in addViewAt, and it runs only when the old parent no longer lists the view.
  • Views that are not inserted again keep their hold, so exit animations do not change.
  • It adds 7 Robolectric tests. They are in the merged commit.
  • We tested it on an Android emulator with RN 0.88.0 built from source. Without the fix the app crashes; with the fix there is no crash.

The commit should apply cleanly: addViewAt on this branch has the same code as main before the fix.

Activity

  1. added
    Type Pick RequestPick requests to include commits inside a React Native release
    on Nov 5, 2026
  2. github-actions commented on Nov 5, 2026

    @github-actions

    Thank you for opening a new React Native Pick Request.

    These are the criteria we follow when accepting or rejecting a code change into a React Native release branch (source).

    If your Pick Request does not satisfy the criteria below, please close it as it will not be considered.

    ✅ Which Pick Requests we accept
    1. ✅ Fixes for regressions to core APIs. Examples:
      • A core component is behaving differently between versions 0.X and 0.X-1
      • The TurboModule.getEnforcing function is throwing an unexpected assertion error.
    2. ✅ Fixes to bugs in core React Native. Examples:
      • Breakpoints in React Native DevTools not working correctly in the debugger
      • Fast Refresh not working as expected
      • Metro bundler not starting properly or ignoring the configuration file
      • Buttons that are not clickable
    3. ✅ Fixes to APIs used by third-party libraries and out-of-tree platforms. Examples:
      • An API used by react-native-macos is not behaving as expected or is regressing
    4. ✅ Bump of patch version of dependencies. Example:
      • Bump Gradle from 8.11.0 to 8.11.1
    5. ✅ Fixes for low/high severity security vulnerabilities. Example:
      • Bump Gradle from 8.11.0 to 8.12.0 if there is a security vulnerability in 8.11 and no 8.11.x version contains the same fix.
    6. ✅ Fixes and reverts of accidental breaking changes. Example:
      • Reverting or fix-forwarding a Kotlin migration of a file (e.g. ReactRootView.java) if it is causing a breaking change for the React Native ecosystem.
    7. ✅ Performance improvements. Examples:
      • Fixing unnecessary re-renders in FlatList.
    8. ✅ Any Pick Request if the release is still in RC0 (after RC1, the previously listed criteria apply)
    ❌ Which Pick Requests we don't accept
    1. ❌ Any Pick Request that introduces a breaking change after RC1. Example:
      • A bugfix that contains a refactoring, resulting in changes to the public API of a class
    2. ❌ Any Pick Request that introduces a new feature after RC1. Example:
      • A commit that introduces a new API or a specific feature for a component.
    3. ❌ Bump of major or minor version of dependencies. Examples:
      • Bump Gradle from 8.11.0 to 8.12.0
      • Bump Gradle from 8.11.0 to 9.0.0
    4. ❌ Bump of a dependency to a pre-release version. Example:
      • Bump Gradle from 8.11.0 to 8.11.1-beta.1
    5. ❌ Any Pick Request that introduces changes to the React Native testing infrastructure after RC1. Examples:
      • Changes to GitHub Actions workflows to optimize them, even if they are on main.
      • Changes to the logic used to publish packages to NPM or Maven Central
    6. ❌ Pick Request composed of multiple commits that have several merge conflicts.
      • If your Pick Request is too complex to apply to the release branch, it will be rejected.
    7. ❌ Any non-critical improvement that landed on main.
      • These will generally ship in the following version unless they fit one of the criteria above.
    8. ❌ Any Pick Request considered a "nice to have".
      • Even one-line changes carry a risk of destabilizing and further delaying the release.
    ℹ️ What makes for a good Pick Request

    In order for your Pick Request to be considered, please do the following:

    • ℹ️ Limit your Pick Request to one commit from main, or one PR against the release branch.
    • ℹ️ Include a clear explanation of why your Pick Request should be considered, ideally referencing one of the criteria above.
    • ℹ️ Target only one minor version of React Native (e.g. [0.76]). To have your Pick Request applied to more versions, please open separate Pick Requests.
  3. fabriziocucci commented on Nov 8, 2026

    @fabriziocucci
    Collaborator

    Picked into 0.89-stable for 0.89.0-rc.1 as f1cf8a1ddbf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type Pick RequestPick requests to include commits inside a React Native release

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions