fix(android): convert outlineColor values before delegation#57558
Open
whizzkid1452 wants to merge 2 commits into
Open
fix(android): convert outlineColor values before delegation#57558whizzkid1452 wants to merge 2 commits into
whizzkid1452 wants to merge 2 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
whizzkid1452
changed the title
whizzkid1452
force-pushed
the
bug/outline-color-conversion
branch
from
e110484 to
7435ea2
Compare
facebook-github-tools
Bot
added
the
Shared with Meta
Abbondanzo
approved these changes
Jul 15, 2026
| ViewProps.OUTLINE_COLOR -> | ||
| mViewManager.setOutlineColor( | ||
| view, | ||
| // outlineColor의 nullable 계약을 보존하기 위해 기본값이 없는 변환을 사용한다. |
Contributor
There was a problem hiding this comment.
Thanks for the contribution! Could you convert this code comment to English?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
outlineColorvalues withColorPropConverterbefore delegating them to the view manager.Doublecolor values that previously threwClassCastException.Fixes #57190
Changelog:
[Android] [Fixed] - Fix crashes when
outlineColoris provided as a numeric color valueTest plan
ClassCastExceptionbefore the fixBaseViewManagerDelegateTest:packages:react-native:ReactAndroid:testnpx prettier --write .@react-native/specs/react-native-modulesfor the unchangedNativeDevMenu.jsfile withSyntaxError: Unexpected token '{'