Repository navigation
Finding a base's name facts without vectors reads only its name facts (#1318, ahead of upstream) - #10
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: Bogdan Szabo <[email protected]> (cherry picked from commit 8ed5ef6)
…ges it, and the schema counts 104 files
gedaiu
force-pushed
the
rc/name-facts-by-predicate
branch
from
October 19, 2026 08:23
80aad17 to
040eed1
Compare
gedaiu
added a commit
to re-cinq/lore
that referenced
this pull request
Oct 19, 2026
0.1.0-re.16 = re.15 + re-cinq/utopia#10 (a base's name facts are read through a predicate index, fork migration 9001) + #12 (containment recall: JIT off, alias facts through that index, a pg_trgm index on entity names in fork migration 9002, and the reverse branch matched by the mention's substrings). Containment took 1.1 s per call on re-cinq/lore's base and pinned the Utopia DB during memory extraction; seeded at the same size it now takes ~15 ms. Tag `v0.1.0-re.16` (re-dev `807cd59f`), digest `sha256:04294e27650ddb17b1884bce6b8d9f2384afd2075e3b0e58094c8519fcfbd1a6`. Two migrations run on start. Needs a terraform apply from main. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings deeplethe#1318 into
re-devahead of upstream's review, so Lore can run it now. Its heade2557d62is cherry-picked unchanged.name_vectors::pendingfinds a base's liveknown_asfacts without vectors through an index on(kb_id, predicate_id, id) WHERE invalidated_at IS NULL, instead of reading every fact of the base by id. That's 200,000 rows per document on a 200,000-fact base, for a handful of names.Fork adaptation, one commit. Upstream's migration
0115is9001_a_name_fact_is_found_by_its_predicate.sqlhere (RE-CINQ.md: fork migrations from 9000, idempotent). It has the sameCREATE INDEX IF NOT EXISTS facts_live_predicate_idx …, the name and columnsname_vectors_plan_tests.rsasserts. When a sync brings0115, whichever runs second is a no-op, andCURRENT_SCHEMA_VERSIONis recounted then (105). It is 104 now: 102 upstream files,9000and9001.re-dev's fork job that fills name vectors once per base (0c56fd13) still callspendingwith the same signature. deeplethe#1318 only rewrites its SQL. Whether that job is still needed now that this index exists is a separate decision.Checked with the author session (utopia-8b), which isn't changing deeplethe#1318.
🤖 Generated with Claude Code