fix(money-bots): show the strategies, keep the reasons (v0.24.1) - #110
Merged
Conversation
The board sat empty and told the operator a probe had run. That was the
wrong call twice over: it copied /pki's "storing nothing is a feature"
design onto a board whose entire job is to answer "how do I make money
with a bot", and it threw away the most useful thing the engine produced
— a specific, quantified reason a plausible-looking strategy does not
work — into a log nobody reads.
- a knocked-down draft is now FLAGGED, not deleted. panel_verdict rides
on the spec (vetted / below-bar / flagged) and the card shows it, with
the objection that killed it. Only two things still block storage: the
legality veto, and no spec at all
- the page leads with the strategies (vetted, then flagged and exactly
why); the mechanism corpus moved back to a collapsed block at the
bottom where the operator asked for it
- "Churn Now" is now "Generate one now", and says what it is doing —
it runs a full probe cycle, which takes minutes
- admit rate still counts only vetted strategies, so storing the flagged
ones cannot inflate it
Also fixes a live false positive in the legality veto: an honest
enumerated disclaimer ("this is not market manipulation, wash trading, or
front-running") put the negation cue 30+ chars from the last term and
vetoed a clean strategy. The legality note now uses sentence-scoped
negation — that field exists to say what the strategy does NOT do — while
prose keeps the tight window that catches "never intends to fill... i.e.
spoofing".
First strategy the reworked pipeline stored: a Hyperliquid perp-perp
funding spread carry, flagged because the draft quoted a one-way fee as a
round trip and the correction makes every trade net-negative.
2121 tests passing.
Co-Authored-By: Claude <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
The board sat empty and told the operator a probe had run.
That was wrong twice: it copied
/pki's "storing nothing is a feature" design onto a board whose entire job is to answer how do I make money with a bot, and it discarded the most useful thing the engine produced — a specific, quantified reason a plausible-looking strategy does not work — into a log nobody reads.What changed
panel_verdict(vetted/below-bar/flagged) rides on the spec, and the card shows it alongside the objection that killed it. Only two things still block storage: the legality veto, and no spec at all.Veto false positive (found live)
An honest enumerated disclaimer — "this is not market manipulation, wash trading, or front-running" — put the negation cue 30+ characters from the last term and vetoed a clean strategy, costing a full generation plus a four-lens panel.
The legality note now uses sentence-scoped negation, because that field exists to say what the strategy does not do. Prose keeps the tight window, which is what catches "places orders it never intends to fill to move the price — spoofing".
First stored strategy
A Hyperliquid perp-perp funding spread carry — flagged, because the draft quoted a one-way fee as a round trip:
That correction makes every trade net-negative. It's on the board with that reasoning attached, which is the point.
Verification
ruff check+ruff format --checkcleanGenerated with Claude Code