Skip to content

ggml-openvino : fix clangd and MSVC warnings, enforce internal linkage - #320

Merged
ravi9 merged 2 commits into
ravi9:dev_backend_openvinofrom
mostafafaheem:linter_fixes
Sep 17, 2026
Merged

ravi9 merged 2 commits into
ravi9:dev_backend_openvinofrom
mostafafaheem:linter_fixes

Conversation

@mostafafaheem

@mostafafaheem mostafafaheem commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

It's a huge diff but it's mostly copy pasting functions around to fix undeclared errors

  1. Enforces internal linkage when possible, in ggml-quants.h / ggml-quants.cpp, utils.h / utils.cpp, openvino/utils.h / openvino/utils.cpp. Not exhaustive, since some utilities might need to be public, so limited to functions only used once, like graph compute, weight extraction, quantize_*, etc.
  2. Fixes clangd linter warnings about using std::endl, unused includes and pragmas, using const and const reference when possible, calling static GgmlOvDecoder methods by their class instead of an instance, integer to pointer casting, and other minimal changes.
  3. Fixes 1 MSVC warning about mismatched types.

No functional differences otherwise.

@ravi9
ravi9 merged commit 40a2a96 into ravi9:dev_backend_openvino Sep 17, 2026
4 of 16 checks passed
@mostafafaheem
mostafafaheem deleted the linter_fixes branch September 17, 2026 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants