ggml-openvino : fix clangd and MSVC warnings, enforce internal linkage - #320
Merged
Merged
Conversation
…duplicate switch case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a huge diff but it's mostly copy pasting functions around to fix undeclared errors
ggml-quants.h/ggml-quants.cpp,utils.h/utils.cpp,openvino/utils.h/openvino/utils.cpp. Not exhaustive, since some utilities might need to be public, so limited to functions only used once, like graph compute, weight extraction,quantize_*, etc.clangdlinter warnings about usingstd::endl, unused includes and pragmas, usingconstandconstreference when possible, calling staticGgmlOvDecodermethods by their class instead of an instance, integer to pointer casting, and other minimal changes.No functional differences otherwise.