RDBC-1098 - Port 7.2.3 -> 7.2.5 - #574
Open
M4xymm wants to merge 18 commits into
Open
Conversation
… EditClientCertificateOperation
…ueue brokers, fix QueueSink mentorNode field name
…cord and smuggler types, add pull replication cursors
…es README sections
… conversation messages and time series no-op delete
…ationMessagesOperation
…ionStringsOperation and database record responses
Ports the client-visible tests from the C# 7.2.5 test patch: - RavenDB_14311: invalid RQL with extra parentheses reports a syntax error instead of a NullReferenceException; valid search() still works - RavenDB_26935: non-ASCII term truncation on a Lucene index - RavenDB_26921: prefix/suffix search operator on static and dynamic (createField) index fields - RavenDB_24423: Bengali strings sorted with AlphaNumeric ordering - TimeSeriesStatsUpdate: deleting a range of a non-existing time series is a no-op The remaining tests in the patch exercise server internals (CDC sink, task errors storage, replication change-vector gating, Voron, Corax pipeline, revision PK hashing, sharding, PostgreSQL integration, SNMP) and have no Node.js client counterpart.
…for missing conversation
…lity: - Conditional test skips for features requiring RavenDB 7.2+. - Handle null bodyStreams in `GetOngoingTaskInfoOperation`. - Upgrade dependencies (`package-lock.json`) to version 7.2.7.
- Default forcePathStyle and disableChecksumValidation to false so RemoteAttachmentsS3Settings always serializes both booleans, matching the C# ToJson wire format - Use explicit != null checks for the opt-in SSO fields in EditClientCertificateOperation and type the payload as Record<string, unknown> - Build the GetServerWideConnectionStrings query string with URLSearchParams - Point-free map and inferred return type for serializeSnowflakeEtlTable
kalczur
requested changes
Aug 31, 2026
| this._thumbprint = parameters.thumbprint; | ||
| this._permissions = parameters.permissions; | ||
| this._clearance = parameters.clearance; | ||
| this._disabled = !!parameters.disabled; |
There was a problem hiding this comment.
Do we want treat disabled undefined as false here? It's different for allowAnySsoServer
| private readonly _connectionString: T; | ||
|
|
||
| /** | ||
| * @param connectionString - The connection string to remove. Only the name property is required. |
There was a problem hiding this comment.
What about connectionString.type? It is used in createRequest
| .objectKeysTransform({ | ||
| defaultTransform: ObjectUtil.camel, | ||
| ignorePaths: [ | ||
| /^\w+ConnectionStrings\.[^.]+$/i |
There was a problem hiding this comment.
It can't match a name with a dot in it, so My.App.Raven comes back as my.App.Raven
There was a problem hiding this comment.
Please check other [^.]+$ matches in project
| for (const item of raw.results ?? []) { | ||
| // Each entry is the underlying connection string's fields flattened to the top level, | ||
| // plus type and excludedDatabases (matches the C# ServerWideConnectionString wire format). | ||
| const { excludedDatabases, usedBy, ...connectionStringFields } = item; |
There was a problem hiding this comment.
Shouldn't it return usedBy? IIRC we are returning this for server-wide cs in server/studio.
Comment on lines
+91
to
+93
| const operation = typeof conversationIdOrParameters === "string" | ||
| ? new GetConversationMessagesOperation(conversationIdOrParameters) | ||
| : new GetConversationMessagesOperation(conversationIdOrParameters); |
| uriParams.append("after", DateUtil.utc.stringify(this._parameters.after)); | ||
| } | ||
|
|
||
| uriParams.append("pageSize", (this._parameters.pageSize ?? 2_147_483_647).toString()); |
There was a problem hiding this comment.
IIRC the server default is int.MaxValue, so just omit it when it isn't defined
| console.log(result.taskId); // the ID of the created ongoing task | ||
| ``` | ||
|
|
||
| #### Update a CDC Sink task |
There was a problem hiding this comment.
What about server-wide connection strings, Snowflake ETL, the three new queue brokers and SSO certificate params?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue link
https://issues.hibernatingrhinos.com/issue/RDBC-1098
Additional description
mentorNodefield nameAiOperations.getConversationMessageswith conversation message types; returns null result for a missing conversationEditClientCertificateOperationdisableChecksumValidationto S3 settingsGetConnectionStringsOperationand database record responsesType of change
How risky is the change?
Backward compatibility
Is it platform specific issue?
Documentation update
Documentation Requiredtag.Testing by Contributor
private)Testing by RavenDB QA team
QA Requiredtag.Is there any existing behavior change of other features due to this change?
UI work
Studio Requiredtag.