splashasm: Add port option and bump version - #212
Open
SherbertLemon64 wants to merge 1 commit into
Open
Conversation
pelwell
reviewed
Sep 4, 2026
Collaborator
There was a problem hiding this comment.
You should document the Port field
Author
There was a problem hiding this comment.
good spot, added some documentation
SherbertLemon64
force-pushed
the
master
branch
from
September 4, 2026 15:30
fabd200 to
121a52d
Compare
With the rp1 support, the port cannot be assumed as there are now multiple usable ports. Add in a port option, since this is a silently breaking change, bump version
SherbertLemon64
force-pushed
the
master
branch
from
September 4, 2026 15:34
121a52d to
0cb7f4a
Compare
Author
|
I've also realised that the previous model of limiting pin choice doesn't really work unless I am willing to list out all the spi pins on RP1, I've downgraded it to a warning now, but I'll have a think whether it is work maintaining a pin map here or not |
pelwell
reviewed
Sep 4, 2026
| Port : Sets the output block we will be writing to, this | ||
| needs to be in agreement with the pins to get an | ||
| output. Not relevant for Pis earlier than the Pi 5 | ||
| Reserved : three pad bytes (struct alignment after Size), always |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the rp1 support, the port cannot be assumed as there are now multiple usable ports. Add in a port option, since this is a silently breaking change, bump version
Do not merge until the firmware is updated