README.md - clarify which Pis this doesn't work with - #211
Closed
andrum993 wants to merge 1 commit into
Closed
Conversation
The page currently says this code works on `everything but the Pi 5` - it also doesn't work on the CM5, Pi 500 and Pi 500+. Add the word `family` to make this a bit more accurate, to try to avoid any misunderstanding.
popcornmix
reviewed
Sep 4, 2026
| - You can have a maximum of 10 I2C defines | ||
| - The delays are blocking and therefore a long splash description will slow down a boot | ||
| - The only timing guarantee is that if you write a delay command, there will be a wait strictly greater than your delay command. This is not made for timing sensitive applications, there are further delays due to parsing No newline at end of file | ||
| - The only timing guarantee is that if you write a delay command, there will be a wait strictly greater than your delay command. This is not made for timing sensitive applications, there are further delays due to parsing |
Contributor
There was a problem hiding this comment.
was this sentence intentionally edited? I don't immediately see a change so I'm suspecting an accidental newline/whitespace change.
Contributor
Author
There was a problem hiding this comment.
Sorry - I did not make any change to this line - I just added "family" using Github's online editor. Shall I close this PR and do a more careful edit? Or shall I leave it to a professional (if this PR is deemed a good idea)?
Collaborator
There was a problem hiding this comment.
There was previously no newline, so this is an improvement. There's also some trailing whitespace in places.
Collaborator
|
Superceded by 65bad73. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The page currently says this code works on
everything but the Pi 5- it also doesn't work on the CM5, Pi 500 and Pi 500+. Add the wordfamilyto make this a bit more accurate, to try to avoid any misunderstanding.