Repository navigation
kmod-parser: modules.builtin duplicate handling - #281
Merged
Merged
Conversation
ddiss
force-pushed
the
kmod-parser-dups
branch
from
October 22, 2026 04:35
dfa9c21 to
0f3a334
Compare
Collaborator
Author
|
v2: run |
Commit 5afc74d ("kmod-parser: fail with duplicate dep/builtin modules") incorrectly assumed unique module names. We need to handle then as e.g. 6.12.113+deb13-cloud-arm64/modules.builtin contains: kernel/drivers/bus/arm-cci.ko kernel/drivers/perf/arm-cci.ko As a workaround, ignore modules.builtin duplicates and retain the first entry, which may come from modules.dep. Duplicate entries in (only) modules.dep will still result in failure, but we can hopefully get away with that for now. Rework the test to check for the new behaviour. Link: rapido-linux#279 Signed-off-by: Sangeetha Thackarajan <[email protected]> Signed-off-by: David Disseldorp <[email protected]>
ddiss
force-pushed
the
kmod-parser-dups
branch
from
October 22, 2026 09:54
0f3a334 to
6f97b30
Compare
Collaborator
Author
|
v3: squash and add Sangeetha's sign-off following discussion |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.