Repository navigation
chore(templates): router ^0.18.0, create-rango 0.2.4 - #2
Merged
Merged
Conversation
Template pins move to @rangojs/router ^0.18.0 and create-rango to 0.2.4. No template code changes: the templates use none of the APIs 0.18.0 changes (ppr, cache(), theme reads, cookies()/headers(), tag invalidation).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@rangojs/router 0.18.0 is published (rangojs/rango#984, release https://github.com/rangojs/rango/releases/tag/v0.18.0). This PR moves the template pins to
^0.18.0and bumps create-rango to 0.2.4 for republishing.No template code changes. The templates use none of the APIs that 0.18.0 changes:
pprand shell behaviorcache()keyscookies()/headers()in cached loadersupdateTag/revalidateTagcreate-rango already rewrites the router pin to the registry's
latestat scaffold time, so new scaffolds get^0.18.0without this PR. What this PR changes is the committed pin: it's the fallback when the registry lookup fails (orCREATE_RANGO_SKIP_LATESTis set), and it's what the repo's own checks build against.Changes
templates/{basic,basic-js,cloudflare,vercel}/package.json:@rangojs/router^0.17.0->^0.18.0packages/create-rango/package.json:0.2.3->0.2.4pnpm-lock.yaml:@rangojs/[email protected]Test plan
check:generated, typecheck, lint, format, build (all 4 templates, against the published 0.18.0)test:unit(4 templates), create-rangosmoke.mjs(4 templates),test:runtime(4 templates, dev + production)pack-smoke.mjs: fails locally withnpm error Cannot read properties of null (reading 'edgesOut')from npm 10.9.3 on this machine. It fails the same way onmain(40f4bf8), so CI is the check for it.After merge: run
publish.ymlto publish create-rango 0.2.4.