Repository navigation
chore: batch #1255 (S22 content-negotiation pilot) and #1302 (zod 4.6.6) - #1319
Merged
Merged
Conversation
…st unit suites (S22 pilot) The HTTP-only content-negotiation e2e cases (79 tests across the router test-app and cloudflare-basic, dev and production) move to unit suites that run the production request path: dispatch for a response variant's win, serveShellRequest for a page route's win and its document or flight representation. Each app keeps one dev and one production smoke for what a unit suite cannot see: the route trie the build emits and the real SSR document (and workerd, in cloudflare-basic). cloudflare-basic's negotiated routes move into src/pages/negotiation.tsx, included without a name scope, so its unit suite dispatches the app's own routes. Route names and router.named-routes.gen.ts are unchanged. The test-app's /negotiate-mw-test, used only by the removed e2e cases, is removed and its generated route files regenerated. The testing skill notes that a negotiated URL's page-route win goes through serveShellRequest.
Bumps [zod](https://github.com/colinhacks/zod) from 4.4.3 to 4.6.6. - [Release notes](https://github.com/colinhacks/zod/releases) - [Commits](colinhacks/zod@v4.4.3...v4.6.6) --- updated-dependencies: - dependency-name: zod dependency-version: 4.6.6 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
devcorner: rango-t84 · session rango-s448
This batch lands #1255 and #1302 on main together, with one CI run. Each PR's head is merged with
--no-ff, so both PRs close as merged when this does.dispatchandserveShellRequestunit suitesapps/docsNeither changes router source, and no consumer-visible behaviour changes. The CHANGELOG is unchanged.
How it was built
batch/1255-1302from main at51d917d5b:1e6ccef62merges test(router): content-negotiation HTTP-only e2e moved to dispatch and serveShellRequest unit suites (S22 pilot) #1255 atcee1c0189, which already contains main;637c4182fmerges chore(deps): bump zod from 4.4.3 to 4.6.6 #1302 atad95a14a6, after dependabot's rebase onto main.check:route-genis current.Checks on the batch head
These passed on
637c4182fbefore the push, with the worktree's own install from the lockfile (zod 4.6.6 inapps/docs):pnpm run typecheck.pnpm run test:unit:all:The new
content-negotiation.rsc-test.tsxsuites run in the router and in cloudflare-basic.pnpm run lintandpnpm run format.Every
check:*script, includingcheck:e2e-parity --strict.check:bundle-guards: the router chunk is 52279 B gzip, unchanged.node --teston thetoolstests: 63/63.The
apps/docsbuild on zod 4.6.6, including its shell prerender: 100 entries.Each PR was green on its own head: #1255 61/61 at
cee1c0189, and #1302 61/61 atad95a14a6.Practices
pnpm run lint,pnpm run formatand everycheck:*script passed on the batch head.pnpm run test:unit:allpassed on the batch head, and this PR's full CI run is the sign-off.skills/testing/response-routes.md.