Repository navigation
Bump next to 15.5.28 and sharp to 0.35.5 (GHSA-2464-fhr4-w9xw) [SECURITY] - #88
Open
superbot-helper wants to merge 1 commit into
Open
superbot-helper wants to merge 1 commit into
superbot-helper wants to merge 1 commit into
Conversation
|
Someone is attempting to deploy a commit to the heyradcode's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bumps
nextfrom 15.5.18 to 15.5.28 inpnpm-lock.yaml, which closes GHSA-2464-fhr4-w9xw (critical, CVSS v4 9.5, CVE-2026-96889). The declared^15.1.6already admits the fix, sowebsite/package.jsonis unchanged and only the lock moves.The vulnerable code is
sharp, notnext. The advisory's workaround is "sharp >= 0.35.5", and the two upstream commits that fix it (5e3b687b,9571ec89) change one line of source each —packages/next/package.json's optional dependency on sharp — plus their own lockfile.next15.5.18 declaressharp: ^0.34.3, so this lock resolved sharp 0.34.5 — libvips 8.17.3, librsvg 2.61.2. Next 15.5.28 declares^0.34.3 || ^0.35.5, which still admits 0.34.5, so bumping next alone would leave the old library installed. This patch moves both: next 15.5.28 and sharp 0.35.5 (libvips 8.18.7, librsvg 2.63.2). The other[email protected]in the tree belongs to@dynamic-labs/iconicand is untouched.Per CVE-2026-96889, the flaw is a use-after-free in librsvg when an SVG contains nested XIncludes with duplicate entity declarations.
SECURITY.md asks for security reports by email rather than a public issue. This one is a dependency bump against an already-public advisory, so I put it here first; if you would rather take it through [email protected], say so and I will.
Component(s)
Reach here: precautionary
I ran both arms with
next startand requested the image optimizer:/_next/image?url=/images/pets/tidefang.png&w=64&q=75→ 200, and an instrumentedsharpwas loaded and called fromnext/dist/server/image-optimizer.js. The optimizer → libvips path is live./_next/image?url=/icon.svg&w=64&q=75→ 400,"url" parameter is valid but image type is not allowed, logged asdangerouslyAllowSVG is disabled.website/next.config.tssets nodangerouslyAllowSVG,remotePatternsis empty, and the site's only SVG is its own fixedicon.svg. So I could not demonstrate the advisory's SVG trigger against this app: the fix is precautionary here, and only becomes load-bearing if someone enables SVG optimization or adds a route that serves SVG.How Has This Been Tested?
pnpm install --frozen-lockfileexit 0 on both arms (pnpm 9.15.9).pnpm buildinwebsite/exit 0 on both arms.next,@next/*,sharpand@img/*; no other package version moves.Not run: a proof-of-concept for CVE-2026-96889 (none is public),
pnpm lint,pnpm test, and any deploy.