services/notifications: document tracked/urgency fields reference gaps - #942
Open
Sniegawa wants to merge 1 commit into
Open
services/notifications: document tracked/urgency fields reference gaps#942Sniegawa wants to merge 1 commit into
Sniegawa wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notification.urgency - Added missing reference to NotificationUrgency enum
Notification.tracked - Updated description to inform user that NotificationServer may set this flag by itself. Also added a warning that if this flag is manually set to true, the notification will be destroyed only after the user explicitly expires/dismisses it or when the NotificationServer when it is notified by sender application.
In depth explanation of commit:
I've had some issues with RetainableLock and Retainable properties of Notification object, it would get destroyed after scope of onNotification. After some time I started digging in the source code and I stumbled upon the tracked flag which by manually changing to true made the NotificationManager not destroy the Notification object immediately after emitting it.
I think that previous description of the tracked field wasn't telling the user all useful information about that flag (especially that NotificationServer can set it to false).