Bump aznet to the idempotent-WriteRaw fix - #10
Open
Atsika wants to merge 1 commit into
Open
Conversation
A failed WriteRaw is resent verbatim by aznet's flush(). When the write had actually landed and only its response was lost, the resend duplicated the chunk and desynced the peer's Noise nonce, which reset the tunnel. WriteRaw now carries a core-owned chunk sequence that each driver maps to its native idempotency primitive, so a resend collides instead of duplicating. Dependency-only change: no proxyblob source touched, and the driver interface change is internal to aznet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up Atsika/aznet#5.
A failed
WriteRawis resent verbatim by aznet'sflush(). When the write had actually landed and only its response was lost, the resend duplicated the chunk and desynced the peer's Noise nonce, resetting the tunnel.WriteRawnow carries a core-owned chunk sequence that each driver maps to its native idempotency primitive (azqueue: message header, aztable: row key → 409, azblob: append-position condition → 412), so a resend collides instead of duplicating.Dependency-only change; no proxyblob source is touched and the aznet driver interface change is internal to aznet.
Verified:
go build ./...,go vet ./...,go test ./... -race -count=1, and the wasm agent build all pass against the bumped module (GOWORK=off, so the published version rather than the local checkout).