Repository navigation
[CI] Install Miniforge in the compile job; include <algorithm> for GCC 15 - #234
Merged
xumingkuan merged 2 commits intoNov 1, 2026
Merged
Conversation
The ubuntu-latest runner image no longer provides a conda installation, so setup-miniconda@v2 failed with "No installed conda 'base' environment found" before anything was compiled. Let setup-miniconda (v3) install Miniforge. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01YFXDzXihmK8D9bNxsBNotC
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are identified for the compile-job update to explicitly install Miniforge.
No open issues 🎉
What changed in this PR
Updates the compile job to install Miniforge explicitly, addressing the setup failure on runners that no longer provide conda.
Changes:
- Upgrades
conda-incubator/setup-minicondafrom v2 to v3. - Adds
miniforge-version: latestwhile preserving the existing Quartz environment configuration.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Installs Miniforge during compile-job setup instead of relying on preinstalled conda. |
Review effort: Balanced
kernel.cpp uses std::find without including <algorithm>; GCC 15 (now on the ubuntu-latest runner) no longer provides it transitively. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01YFXDzXihmK8D9bNxsBNotC
liupengy19
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
compilejob fails before compiling anything: theubuntu-latestrunner image no longer provides a conda installation, soconda-incubator/setup-miniconda@v2stops with(e.g. the run of #233). The last successful run on master is from 2026-10-06.
This PR
setup-miniconda@v3withminiforge-version: latest(Miniforge defaults to conda-forge, so the job does not depend on a preinstalled conda);#include <algorithm>tosrc/quartz/simulator/kernel.cpp, which usesstd::find: the runner now has GCC 15.2, whose headers no longer include it transitively, so the compile step failed once conda was fixed.Checked locally by running the job's steps in a
gcc:15.2container (Miniforge,env.yml,cmake,make install, the Cython build): all 41 targets build and the Cython build succeeds.🤖 Generated with Claude Code
https://claude.ai/code/session_01YFXDzXihmK8D9bNxsBNotC