fix: implement missing utilities and fix edge-case bugs - #309
Open
stooit wants to merge 1 commit into
Open
Conversation
- calculator: divide throws on division by zero instead of returning Infinity - string-utils: wordCount collapses consecutive whitespace; implement truncate at word boundary with ellipsis - task-manager: implement remove, update, and sortBy - date-utils: formatRelative uses Math.round so 36h rounds to 2 days ago - validator: isEmail accepts long TLDs; isUrl accepts URLs with ports All 60 tests pass; tsc --noEmit clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 previously-failing tests across 5 source files. All 60 tests now pass and
tsc --noEmitis clean understrict: true. No test files modified, no dependencies added.Changes
calculator.ts—dividenow throws on a zero divisor (was returningInfinity); guard catches both0and-0.string-utils.ts—wordCountsplits on/\s+/against the trimmed string so runs of whitespace collapse to one delimiter; implementedtruncate(word-boundary cut with"..."counting towardmaxLength, unchanged when it already fits).task-manager.ts— implementedremove,update, andsortBy(priority high>medium>low, createdAt oldest first).date-utils.ts—formatRelativeusesMath.roundinstead ofMath.floor, so 36h rounds to "2 days ago".validator.ts—isEmailTLD quantifier relaxed{2,4}→{2,}to accept long TLDs (e.g..museum);isUrlno longer rejects URLs with ports.Verification
bun test: 60 pass / 0 failtsc --noEmit: cleanAssumptions / notes (not pinned by tests)
updateclearsdescriptionwhen passed{description: undefined}(uses"description" in changes);title/priorityuse!== undefinedto respect their non-optional types.sortBy("status")has no test coverage — chose workflow order pending → in_progress → completed.sortBy("createdAt")ties rely on stable sort + Map insertion order (ES2019 guarantees stability).truncatewith a negative/NaNmaxLengthis unguarded. No caller passes negative values and it is untested, so left out of scope per "fix only what the tests require".