fix: make all tests pass — implement missing functions and fix edge-case bugs - #308
Open
stooit wants to merge 1 commit into
Open
fix: make all tests pass — implement missing functions and fix edge-case bugs#308stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
…ests - calculator: throw on division by zero instead of returning Infinity - date-utils: use Math.round for relative-day formatting (off-by-one) - string-utils: fix wordCount for consecutive whitespace; implement truncate - task-manager: implement remove, update, and sortBy methods - validator: accept long TLDs in isEmail and ports in isUrl All 60 tests pass (was 44 pass / 16 fail); no test files or dependencies changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 failing tests in the utility library. Suite now: 60 pass / 0 fail (was 44 pass / 16 fail). No test files modified, no dependencies added.
Changes
src/calculator.ts—dividenow throws on division by zero instead of returningInfinity.src/date-utils.ts—formatRelativeusesMath.roundfor the day count, fixing the off-by-one (36 hours ago → "2 days ago").src/string-utils.ts—wordCountcollapses consecutive whitespace (splits on/\s+/); implementedtruncate(word-boundary truncation with"..."counting towardmaxLength, returns unchanged when within limit).src/task-manager.ts— implementedremove(returns bool),update(title/description/priority, returns bool), andsortBy(priority high>medium>low, createdAt oldest-first, status).src/validator.ts—isEmailaccepts long TLDs (e.g..museum);isUrlaccepts URLs with a port (e.g.http://localhost:3000). Protocol allow-list preserved (javascript:,data:,ftp:still rejected).Verification
bun test→ 60 pass / 0 failtsc --noEmit→ cleanScope & assumptions
Per task constraints ("fix only what the tests require"), changes are limited to what the failing tests exercise. Review surfaced a few latent edge cases not covered by any test (leading-whitespace in
truncate, clearing an optionaldescriptionviaupdate, non-numeric-id tiebreak insortBy, and theisUrl/isEmailpermissiveness as a display-only validator vs. an egress/SSRF guard). These were intentionally left out of scope to avoid changing untested behaviour; they can be tracked as follow-ups if desired.🤖 Generated autonomously.