platforms/iq-x7181-evk: remove the ADSP filenames - #153
platforms/iq-x7181-evk: remove the ADSP filenames#153Vivek Magre (vmagre) wants to merge 1 commit into
Conversation
baae017 to
fdd77b2
Compare
Dmitry Baryshkov (lumag)
left a comment
There was a problem hiding this comment.
First the definition of the issue, then actions to be performed.
2ba1b59 to
e4b82a0
Compare
|
Hi Dmitry Baryshkov (@lumag) |
Dmitry Baryshkov (lumag)
left a comment
There was a problem hiding this comment.
Still. What it the issue that you are trying to fix?
|
Hi Dmitry Baryshkov (@lumag) |
|
Vivek Magre (@vmagre) please add that information to the commit message. Make sure that it follow the logic: start with the description of the issue before describing the fixing mesaures. |
a89c682 to
a9aa780
Compare
|
Hi Dmitry Baryshkov (@lumag) |
Dmitry Baryshkov (lumag)
left a comment
There was a problem hiding this comment.
Are you sure about the ADSP firmware being not necessary before HLOS? Isn't it being loaded by the bootloaders to handle USB-C and charging before Linux boots?
Also, there is no need to update something before it happens. The PR updating to the next boot firmware revision can include this commit.
Last, but not least.
Updating the partition file to prevent build failures in meta-qcom caused by missing files in future releases.
This line is too long and also doesn't follow commit guidelines.
|
Hi Dmitry Baryshkov (@lumag) , i have confirmed offline with the platform team, the ADSP early boot is not enabled for the IQX7181/IQX5121, the ADSP early boot is enabled for the QCS615, QCS8300, QCS9100, QCS6490 targets. |
The ADSP files (adsp_lite.lzma and adsp_dtbs.elf) are currently included in the tech package as part of boot critical binaries. However, the ADSP upstream firmware is already provided via the upstream firmware package and is included in the HLOS (rootfs), mounted at: /lib/firmware/qcom/x1e80100/ The copies in the boot critical binary zip are not utilized by HLOS and are therefore redundant. Additionally, ADSP files are not required as boot critical binaries. Starting from upcoming tech package releases, adsp_lite.lzma and adsp_dtbs.elf will no longer be included in the tech package. Updating the partition file to prevent build failures in meta-qcom caused by missing files in future releases. Signed-off-by: Vivek Magre <[email protected]>
a9aa780 to
7bb26dc
Compare
|
Updated the commit message to resolve line length, |
Dmitry Baryshkov (lumag)
left a comment
There was a problem hiding this comment.
upstream firmware package and is included in the
HLOS (rootfs), mounted at:/lib/firmware/qcom/x1e80100/
No, it's not mounted there.
The copies in the boot critical binary zip are not
utilized by HLOS and are therefore redundant.
Additionally, ADSP files are not required as boot
critical binaries.
And what does that have to do with the firmware being flashed to the corresponding partitions?
Finally, if we do no longer want to flash those, why don't we also remove the partitions?
Finally, now your commit message have too short lines. What is the standard recommended length? Which line length did you set in your editor?
Removing the adsp_lite.lzma and adsp_dtbs.elf file name.
The ADSP files are not boot critical binary those are included in HLOS.