packaging: accept the DKMS module list as a build input - #90
Open
Christopher Obbard (obbardc) wants to merge 1 commit into
Open
packaging: accept the DKMS module list as a build input#90Christopher Obbard (obbardc) wants to merge 1 commit into
Christopher Obbard (obbardc) wants to merge 1 commit into
Conversation
The set of bundled out-of-tree modules is currently declared twice in the packaging tree: once in debian/dkms-modules and once in the Build-Depends of debian/control.in. Both have to be edited together and neither can differ between kernel variants or deliveries. Take the list as one comma-separated input instead: prepare-source.sh --dkms, build-kernel.sh --dkms, or DKMS_MODULES= passed straight to "debian/rules prepare" and generate both files from it. control.in gains a @DKMS_BUILD_DEPENDS@ placeholder that expands to ", dkms, <name>-dkms..." (nothing at all for an empty list) and dkms-modules becomes a generated file written on every prepare, so a missing manifest still means prepare never ran rather than an empty module set. Entries are validated at prepare time: package-name stem, no -dkms suffix, no duplicates. Nothing is bundled unless a build asks for it; CI passes the list from the dkms field of ci/build-matrix.json. Signed-off-by: Christopher Obbard <[email protected]>
Contributor
|
Nice, this is the piece #89 was missing, and generating both from one variable is the right call. The One thing: |
Christopher Obbard (obbardc)
temporarily deployed
to
Staging
August 28, 2026 20:07 — with
GitHub Actions
Inactive
Christopher Obbard (obbardc)
temporarily deployed
to
Staging
August 28, 2026 20:07 — with
GitHub Actions
Inactive
Christopher Obbard (obbardc)
temporarily deployed
to
Staging
August 28, 2026 20:08 — with
GitHub Actions
Inactive
Christopher Obbard (obbardc)
temporarily deployed
to
Staging
August 28, 2026 20:08 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The set of bundled out-of-tree modules is currently declared twice in the packaging tree: once in debian/dkms-modules and once in the Build-Depends of debian/control.in. Both have to be edited together and neither can differ between kernel variants or deliveries.
Take the list as one comma-separated input instead: prepare-source.sh --dkms, build-kernel.sh --dkms, or DKMS_MODULES= passed straight to "debian/rules prepare" and generate both files from it. control.in gains a @DKMS_BUILD_DEPENDS@ placeholder that expands to ", dkms, -dkms..." (nothing at all for an empty list) and dkms-modules becomes a generated file written on every prepare, so a missing manifest still means prepare never ran rather than an empty module set.
Entries are validated at prepare time: package-name stem, no -dkms suffix, no duplicates.
Nothing is bundled unless a build asks for it; CI passes the list from the dkms field of ci/build-matrix.json.
This is the sister-PR of #89; both are needed to land at the same time.