ci: clean up kernel_config - #83
Conversation
Christopher Obbard (obbardc)
changed the title
"kernel_config" is currently a comma-separated string. Switch the value in the matrix to a native JSON array instead. Signed-off-by: Christopher Obbard <[email protected]>
Since 5cd4aae all config fragments from `debian/config-available/` are applied automatically. `kernel_config` therefore only needs to list additional `intree:` fragments. Drop the redundant fragment list and update the workflow inputs to allow an empty list without restoring the old defaults. No change to the resulting kernel configuration. Signed-off-by: Christopher Obbard <[email protected]>
db600c2 to
190477a
Compare
An "intree:" entry currently names a bare fragment which prepare-source.sh resolves under arch/arm64/configs/, so nothing outside that one directory can be referenced. The kernel ships useful fragments elsewhere, notably kernel/configs/debug.config. Spell the whole path relative to the kernel source root instead, e.g. intree:arch/arm64/configs/qcom_debug.config. Every directory in the tree becomes reachable and the entry says exactly which file it activates rather than leaving the directory implicit. Validate the new form while resolving the matrix, so a typo fails here instead of deep inside the build container: an "intree:" path must be relative and end in .config, with absolute paths and ".." traversal rejected. Fragments land in debian/config/ under their basename, so also reject two entries resolving to the same basename, which the wider namespace now makes reachable (arch/arm64/configs/hardening.config and kernel/configs/hardening.config both exist). Signed-off-by: Christopher Obbard <[email protected]>
The qcom-next-debug variant exists to carry the kernel's debugging options, but it activates only arch/arm64/configs/qcom_debug.config. The generic kernel/configs/debug.config, which the kernel maintains as the common debug fragment, was reachable only through build-kernel-deb.yml's --debug toggle and so never applied to the daily and release deliveries. Add it to both qcom-next-debug rows, now that an "intree:" entry can name a path outside arch/arm64/configs/. The variant then gets the same debug configuration whichever path builds it and the fragment stays versioned with the kernel it targets. Signed-off-by: Christopher Obbard <[email protected]>
|
Cleanup half looks good. Dropping the fragment list is the leftover from #76 and the array validation is nicer than the old Landing this together with #86 works for me. One consequence worth flagging: Unrelated, spotted while reading: the |
!74 removes the |
2 participants
Clean up the kernel build matrix and kernel_config handling:
kernel_configas a JSON arraydebian/config-available/Also add additional requested config to
qcom-next-debug.