Skip to content

ci: build-test PRs with existing pipeline in main branch - #77

Merged
Christopher Obbard (obbardc) merged 1 commit into
qcom/debian/latestfrom
wip/obbardc/fix-pr-workflow
Aug 28, 2026
Merged

ci: build-test PRs with existing pipeline in main branch#77
Christopher Obbard (obbardc) merged 1 commit into
qcom/debian/latestfrom
wip/obbardc/fix-pr-workflow

Conversation

@obbardc

@obbardc Christopher Obbard (obbardc) commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Closes: #75

Comment thread .github/workflows/kernel-debusine-build.yml Outdated
@bjordiscollaku

Copy link
Copy Markdown
Contributor

All we need is a premerge yml in qcom/debian/latest (example) that calls to daily yml on pull_request, and daily needs to have workflow_call inputs to be used as reusuable workflow. Daily yml then will automatically parse all matrix variants specifications, and it will delegate to build-kernel-deb, which then delegates to build-kernel-debusine (debian family) AND build-kernel-ubuntu (ubuntu family).

To initiate the whole chain, all is needed is a call to daily.

Comment thread .github/workflows/pr-build.yml Fixed
@obbardc Christopher Obbard (obbardc) changed the title ci: build-test PRs by assembling the kernel source tree ci: build-test PRs with main's daily pipeline Aug 27, 2026
@obbardc
Christopher Obbard (obbardc) force-pushed the wip/obbardc/fix-pr-workflow branch 2 times, most recently from 82ea74d to e9acde3 Compare August 27, 2026 23:12
@obbardc Christopher Obbard (obbardc) changed the title ci: build-test PRs with main's daily pipeline ci: build-test PRs with existing pipeline in main branch Aug 27, 2026
@bjordiscollaku

Copy link
Copy Markdown
Contributor

No concurrency group on this one, so every push to a PR fires another 5 kernel builds and the in-flight ones keep running on the self-hosted pool. The example from the premerge on pkg-linux-qcom-canonical guards it with:

concurrency:
  group: pr-build-${{ github.event.pull_request.number }}
  cancel-in-progress: true

Worth adding here too?

pkg-pr-hook.yml delegated to pkg-build-reusable-workflow.yml, which runs
generate-source-package immediately after checkout. That needs a real
debian/changelog, but this branch ships changelog.in and only
"debian/rules prepare" generates it, inside a kernel tree, since it
reads the version from the kernel Makefile. So the build never started.

The main branch already has a workflow that does all of this: daily.yml
already runs it nightly. Reuse that workflow for PRs.

Closes: #75
Signed-off-by: Christopher Obbard <[email protected]>
Comment thread .github/workflows/pr-build.yml
@obbardc
Christopher Obbard (obbardc) marked this pull request as ready for review August 28, 2026 07:34

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@obbardc
Christopher Obbard (obbardc) merged commit 8cd25bb into qcom/debian/latest Aug 28, 2026
32 checks passed
@obbardc
Christopher Obbard (obbardc) deleted the wip/obbardc/fix-pr-workflow branch August 28, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants