Enable usb0 and usb1 on shikra QLI - #1001
Conversation
|
Merge Check Failed: CR Not Eligible for Merge CR 4652998 is not eligible for merge. The parent software image for kernel.qli.2.0 is not development complete. Entity: Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations. |
Shiraz Hashim (shashim-quic)
left a comment
There was a problem hiding this comment.
arm64: dts: qcom: Add support for usb nodes on Shikra
You missed to add FROMLIST prefix and add Link: tag in the commits.
|
Merge Check Failed: CR Not Eligible for Merge CR 4652998 is not eligible for merge. The parent software image for kernel.qli.2.0 is not development complete. Entity: Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations. |
92c6f5c to
8ef7292
Compare
|
Merge Check Failed: CR Not Eligible for Merge CR 4652998 is not eligible for merge. The parent software image for kernel.qli.2.0 is not development complete. Entity: Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations. |
PR #1001 — validate-patchPR: #1001
Final Summary
|
PR #1001 — checker-log-analyzerPR: #1001
Detailed report: Full report
|
PR #1001 — validate-patchPR: #1001
Final Summary
|
PR #1001 — checker-log-analyzerPR: #1001
Detailed report: Full report
|
This reverts commit 1c76289. Signed-off-by: Akash Kumar <[email protected]>
This reverts commit 90ffd3d. Signed-off-by: Akash Kumar <[email protected]>
…o shikra" This reverts the pm4125_hs_in/pm4125_ss_in typec role-switch wiring introduced by commit 102ec26: - Remove the &pm4125_typec connector node and &pm4125_vbus regulator node (with the pm4125_hs_in/pm4125_ss_in endpoint labels) from shikra-cqm-som.dtsi. - Remove the &pm4125_hs_in/&pm4125_ss_in remote-endpoint stanzas and the &usb_1_dwc3_hs/&usb_qmpphy_out remote-endpoint stanzas from shikra-cqm-evk.dts and shikra-cqs-evk.dts. - Restore usb_1's dr_mode to "peripheral" in both files. The &wifi node and all other content are left untouched. Signed-off-by: Akash Kumar <[email protected]>
Add support for both USB controllers and their respective phys on Shikra. Link: https://lore.kernel.org/all/[email protected]/ Reviewed-by: Konrad Dybcio <[email protected]> Reviewed-by: Manivannan Sadhasivam <[email protected]> Signed-off-by: Krishna Kurapati <[email protected]> Signed-off-by: Akash Kumar <[email protected]>
On Shikra CQS/CQM platforms, usb-role-switch is handled by PM4125 on primary Type-C port and Cypress PD controller CYPD6129 on second Type-C port. On Shikra IQS platform, usb-role-switch is handled by Cypress PD controller CYPD6129 on both Type-C ports. Since those changes are not yet present, enabling both USB controllers in device mode. Link: https://lore.kernel.org/all/[email protected]/ Reviewed-by: Manivannan Sadhasivam <[email protected]> Signed-off-by: Krishna Kurapati <[email protected]> Reviewed-by: Dmitry Baryshkov <[email protected]> Signed-off-by: Akash Kumar <[email protected]>
…roller Add the device-tree binding documentation for the Cypress cypd6129 and cypd6229 dual Type-C PD controllers. These are used on Shikra CQM/CQS/IQS platforms to handle usb-role-switch for the USB Type-C ports over an I2C interface, similarly to the existing cypd4226 binding. cypd6229 is a variant of cypd6129 and is described with a "cypress,cypd6129" fallback compatible string. Link: https://lore.kernel.org/all/[email protected]/ Signed-off-by: Akash Kumar <[email protected]>
Add cypd6129 and cypd6229 compatible strings to the of_device_id match table so the driver binds to boards describing these Cypress PD controllers in their device tree. No other driver changes are needed since the chip is accessed through the same generic UCSI/HPI I2C register protocol as the existing cypd4226 support. Link: https://lore.kernel.org/all/[email protected]/ Reviewed-by: Abel Vesa <[email protected]> Signed-off-by: Akash Kumar <[email protected]>
…ype-C ports On Shikra CQS/CQM platforms, usb-role-switch is handled by PM4125 on the primary Type-C port and Cypress PD controller CYPD6129 on the second Type-C port. On Shikra IQS platform, usb-role-switch is handled by Cypress PD controller CYPD6129 on both Type-C ports. Add the CYPD6129 typec node under i2c3, wire its connector endpoints to the corresponding DWC3 controller ports via remote-endpoint phandles, and switch the associated USB controllers to OTG mode so role switching can take effect. Link: https://lore.kernel.org/all/[email protected]/ Signed-off-by: Akash Kumar <[email protected]>
8ef7292 to
68c445d
Compare
arm64: dts: qcom: shikra: Replace out-of-tree USB DT with upstream lore series (v7 USB nodes + CYPD6129 role-switch v2)
This branch reverts the 3 out-of-tree/FROMLIST/PENDING Shikra USB commits
carried in this tree and replaces them with the equivalent upstream
lore.kernel.org patch series, applied cleanly on top of qcom-6.18.y:
(arm64: dts: qcom: Add support for usb nodes on Shikra, v7)
(arm64: dts: qcom: shikra: Wire up usb-role-switch for USB Type-C ports, v2)
Reverted:
Applied on top (from lore, unmodified upstream patches):
Net effect: shikra-cqm-evk, shikra-cqs-evk, and shikra-iqs-evk now use the
upstream CYPD6129/CYPD6229 UCSI Type-C controller for USB role switching
(via &i2c3/typec@40) instead of the previous PM4125-native typec block,
while shikra.dtsi/shikra-evk.dtsi gain the base usb_1/usb_2 dwc3, USB
HS/QMP PHY, and QUSB2 efuse-trim nodes needed to support them.
All four affected board/SoC DT files were rebuilt with dtc
(qcom/shikra-cqm-evk.dtb, qcom/shikra-cqs-evk.dtb, qcom/shikra-iqs-evk.dtb)
with no warnings or errors.
Signed-off-by: Akash Kumar [email protected]
links: https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/all/[email protected]/
CRs-Fixed: 4652998
CRs-Fixed:: 4635219