Skip to content

QCLINUX: qcom-configs: add XDP kernel configuration - #1742

Open
Eshitha oyyavuru (kppeoyyavuru) wants to merge 1 commit into
qualcomm-linux:tech/all/configfrom
kppeoyyavuru:dpdk_conf
Open

QCLINUX: qcom-configs: add XDP kernel configuration#1742
Eshitha oyyavuru (kppeoyyavuru) wants to merge 1 commit into
qualcomm-linux:tech/all/configfrom
kppeoyyavuru:dpdk_conf

Conversation

@kppeoyyavuru

Copy link
Copy Markdown

Add xdp.cfg with the BPF and XDP-related kernel options required for AF_XDP support used by DPDK net_af_xdp PMD.

@qcomlnxci
qcomlnxci requested a review from a team August 24, 2026 11:23
@qlijarvis

Copy link
Copy Markdown

PR #1742 — validate-patch

PR: #1742

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: No — vendor-specific config change; no lore link expected, but QCLINUX: prefix is required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream (correct for config fragment)
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1742 - qcom-configs: add XDP kernel configuration
Upstream commit: N/A
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream N/A No upstream source; vendor-specific config change
Body preserves rationale ⚠️ Mentions "xdp.cfg" but modifies qcom.config
Fixes tag present/correct N/A Not a bug fix
Authorship preserved N/A Original vendor commit
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/configs/qcom.config Adds 3 BPF/XDP config options in correct alphabetical position

Issues

  1. Missing QCLINUX: prefix — This is a vendor-specific kernel configuration change to arch/arm64/configs/qcom.config. According to kernel-topics conventions, vendor-only commits must be prefixed with QCLINUX:. The subject should be: QCLINUX: qcom-configs: add XDP kernel configuration

  2. Commit message inconsistency — The commit body mentions "Add xdp.cfg" but the actual file modified is qcom.config, not a separate xdp.cfg file. The message should be corrected to: "Add BPF and XDP-related kernel options to qcom.config"

  3. Missing from integration branches — The commit is not present in qcom-next or any kernel topic branch. For a vendor config change, this should typically be present in at least one topic branch before PR submission.

Verdict

Reject — The commit must be amended to add the QCLINUX: prefix and correct the commit message body before merging.

Final Summary

  1. Lore link present: No — vendor-specific config change; no lore link expected, but QCLINUX: prefix is required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream (correct for config fragment)
  4. PR present in qcom-next/topics: Fail — 1/1 commit(s) are missing from both qcom-next and topics

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 3c1e80ceb9fb6978aa94bc0624e7c0003f3b4f6e
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] qcom-configs: add XDP kernel configuration missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1742 — checker-log-analyzer

PR: #1742
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/32721636613

Checker Result Summary
Checker Result Summary
checkpatch Missing Signed-off-by line
dt-binding-check ⏭️ No DT binding changes
dtb-check ⏭️ No devicetree changes
sparse-check ⏭️ No C/H file changes
check-uapi-headers ⏭️ No UAPI changes
check-patch-compliance Missing required subject prefix
tag-check Subject prefix required (unless targeting qcom-next/qcom-next-staging)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1742 - qcom-configs: add XDP kernel configuration
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/32721636613

Checker Result Summary
checkpatch Missing Signed-off-by line
dt-binding-check ⏭️ No DT binding changes
dtb-check ⏭️ No devicetree changes
sparse-check ⏭️ No C/H file changes
check-uapi-headers ⏭️ No UAPI changes
check-patch-compliance Missing required subject prefix
tag-check Subject prefix required (unless targeting qcom-next/qcom-next-staging)

❌ checkpatch

Root cause: Commit 1337c74 is missing the mandatory Signed-off-by: trailer.

Failure details:

ERROR: Missing Signed-off-by: line(s)

1337c74ae3c0f71c8d88c2c8cd77cc0e93084cbe total: 1 errors, 0 warnings, 0 checks, 9 lines checked

Commit 1337c74ae3c0 ("qcom-configs: add XDP kernel configuration") has style problems, please review.

Fix: Add the Signed-off-by: line to the commit message:

git rebase -i <base_sha>   # mark commit 1337c74ae3c0 as 'edit'
git commit --amend -s      # adds Signed-off-by automatically
git rebase --continue

Or manually add to the commit body:

Signed-off-by: Eshitha Oyyavuru <[email protected]>

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git 744d3e1904e3..68b9c24c123e

❌ check-patch-compliance

Root cause: Commit subject "qcom-configs: add XDP kernel configuration" does not start with a required prefix tag.

Failure details:

Checking commit: qcom-configs: add XDP kernel configuration
Commit summary does not start with a required prefix

Fix: Add one of the required prefixes to the commit subject:

Prefix Use when
FROMLIST: Patch posted to lore.kernel.org
FROMGIT: Patch from a maintainer git tree
UPSTREAM: Patch merged into Linus's mainline
BACKPORT: Upstream patch with modifications
QCLINUX: Vendor-only change (note: will still fail this checker)

For a config-only vendor change like this, use:

git rebase -i <base_sha>   # mark commit as 'edit'
git commit --amend -m "QCLINUX: qcom-configs: add XDP kernel configuration"
git rebase --continue

Note: QCLINUX: prefix is not accepted by check-patch-compliance (known limitation for vendor-only commits). If this is vendor-specific configuration with no upstream equivalent, the checker will continue to fail. This is expected behavior for vendor-only changes.

Reproduce locally:

bash ../kernel-checkers/check-patch-compliance.sh --kernel-src . \
  --base 76cde00b1095 --head b5e9a346221f

❌ tag-check

Root cause: Subject line does not start with a required prefix tag.

Applies when: PR target branch is not qcom-next or qcom-next-staging.

Failure details:

Commit 1337c74ae3c0 ("qcom-configs: add XDP kernel configuration"):
subject line does not start with a required prefix.

All branches except qcom-next and qcom-next-staging require one of:

  • FROMLIST: / FROMGIT: / UPSTREAM: / BACKPORT: / QCLINUX: / PENDING: / WORKAROUND:

Fix: Same as check-patch-compliance above — add an appropriate prefix to the subject line.

Note: If this PR targets qcom-next or qcom-next-staging, this check does not apply and can be ignored.


Verdict

2 blockers must be fixed before merge:

  1. Missing Signed-off-by: — Add the mandatory sign-off trailer
  2. Missing subject prefix — Add QCLINUX: (or appropriate prefix) to the subject

Recommended fix (single rebase):

git rebase -i <base_sha>   # mark commit as 'edit'
git commit --amend -s -m "QCLINUX: qcom-configs: add XDP kernel configuration

Add xdp.cfg with the BPF and XDP-related kernel options
required for AF_XDP support used by DPDK net_af_xdp PMD.

Signed-off-by: Eshitha Oyyavuru <[email protected]>"
git rebase --continue

Note on QCLINUX: prefix: If this is a vendor-only config change with no upstream equivalent, using QCLINUX: is correct. However, check-patch-compliance will still fail because it only accepts upstream-linkable prefixes (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:). This is a known limitation of the checker for vendor-specific commits.

Add xdp.cfg with the BPF and XDP-related kernel options
required for AF_XDP support used by DPDK net_af_xdp PMD.

Signed-off-by: Eshitha Oyyavuru <[email protected]>
@kppeoyyavuru Eshitha oyyavuru (kppeoyyavuru) changed the title qcom-configs: add XDP kernel configuration QCLINUX: qcom-configs: add XDP kernel configuration Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants