Skip to content

Ethernet enablement talos-lyra board - #1721

Open
Ajinkya-inchure wants to merge 2 commits into
qualcomm-linux:early/hwe/lyrafrom
Ajinkya-inchure:ainchure/talos-lyra-evk-dts-updates
Open

Ethernet enablement talos-lyra board#1721
Ajinkya-inchure wants to merge 2 commits into
qualcomm-linux:early/hwe/lyrafrom
Ajinkya-inchure:ainchure/talos-lyra-evk-dts-updates

Conversation

@Ajinkya-inchure

Copy link
Copy Markdown

Ethernet enablement for talos-lyra board

@Ajinkya-inchure
Ajinkya-inchure force-pushed the ainchure/talos-lyra-evk-dts-updates branch from 83df8e6 to 4ba3935 Compare August 20, 2026 10:18
@Ajinkya-inchure
Ajinkya-inchure marked this pull request as ready for review August 21, 2026 10:27
@Ajinkya-inchure
Ajinkya-inchure marked this pull request as draft August 24, 2026 07:08
status = "okay";
};

&ethernet {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add nodes in sorted alphabetical order

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed this.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e after u?
how is this sorted?

snps,mtl-tx-config = <&mtl_tx_setup>;

status = "okay";

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing }
have you compiled your change before submitting?


status = "okay";

mdio: mdio

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this under root node

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mdio and rgmii are internal ethernet pins that's why it needs to be part of ethernet node and not root node.

@Ajinkya-inchure
Ajinkya-inchure marked this pull request as ready for review August 24, 2026 07:10
@Ajinkya-inchure
Ajinkya-inchure force-pushed the ainchure/talos-lyra-evk-dts-updates branch from d109f3e to 7577c7f Compare August 24, 2026 10:53
};

&tlmm{

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this extra line

drive-strength = <16>;
};

phy-intr-pins {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p after r?


&spi6 {
status = "okay";
&i2c5 {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i after p?

@Ajinkya-inchure
Ajinkya-inchure force-pushed the ainchure/talos-lyra-evk-dts-updates branch 8 times, most recently from 810a03d to 7990d96 Compare August 26, 2026 10:20

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run checkpatch ?

ERROR: code indent should use tabs where possible
#26: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:214:
+  ^Ipinctrl-0 = <&ethernet_defaults>;$

WARNING: please, no space before tabs
#26: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:214:
+  ^Ipinctrl-0 = <&ethernet_defaults>;$

WARNING: please, no spaces at the start of a line
#26: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:214:
+  ^Ipinctrl-0 = <&ethernet_defaults>;$

ERROR: code indent should use tabs where possible
#27: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:215:
+  ^Ipinctrl-names = "default";$

WARNING: please, no space before tabs
#27: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:215:
+  ^Ipinctrl-names = "default";$

WARNING: please, no spaces at the start of a line
#27: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:215:
+  ^Ipinctrl-names = "default";$

ERROR: code indent should use tabs where possible
#29: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:217:
+  ^Iphy-handle = <&rgmii_phy>;$

WARNING: please, no space before tabs
#29: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:217:
+  ^Iphy-handle = <&rgmii_phy>;$

WARNING: please, no spaces at the start of a line
#29: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:217:
+  ^Iphy-handle = <&rgmii_phy>;$

ERROR: code indent should use tabs where possible
#30: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:218:
+  ^Iphy-mode = "rgmii-id";$

WARNING: please, no space before tabs
#30: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:218:
+  ^Iphy-mode = "rgmii-id";$

WARNING: please, no spaces at the start of a line
#30: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:218:
+  ^Iphy-mode = "rgmii-id";$

ERROR: code indent should use tabs where possible
#32: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:220:
+  ^Isnps,mtl-rx-config = <&mtl_rx_setup>;$

WARNING: please, no space before tabs
#32: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:220:
+  ^Isnps,mtl-rx-config = <&mtl_rx_setup>;$

WARNING: please, no spaces at the start of a line
#32: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:220:
+  ^Isnps,mtl-rx-config = <&mtl_rx_setup>;$

ERROR: code indent should use tabs where possible
#33: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:221:
+  ^Isnps,mtl-tx-config = <&mtl_tx_setup>;$

WARNING: please, no space before tabs
#33: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:221:
+  ^Isnps,mtl-tx-config = <&mtl_tx_setup>;$

WARNING: please, no spaces at the start of a line
#33: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:221:
+  ^Isnps,mtl-tx-config = <&mtl_tx_setup>;$

ERROR: code indent should use tabs where possible
#35: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:223:
+  ^Istatus = "okay";$

WARNING: please, no space before tabs
#35: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:223:
+  ^Istatus = "okay";$

WARNING: please, no spaces at the start of a line
#35: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:223:
+  ^Istatus = "okay";$

ERROR: trailing whitespace
#37: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:225:
+  ^Imdio: mdio $

ERROR: code indent should use tabs where possible
#37: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:225:
+  ^Imdio: mdio $

WARNING: please, no space before tabs
#37: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:225:
+  ^Imdio: mdio $

WARNING: please, no spaces at the start of a line
#37: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:225:
+  ^Imdio: mdio $

ERROR: code indent should use tabs where possible
#38: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:226:
+  ^I{$

WARNING: please, no space before tabs
#38: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:226:
+  ^I{$

WARNING: please, no spaces at the start of a line
#38: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:226:
+  ^I{$

ERROR: code indent should use tabs where possible
#39: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:227:
+  ^I^Icompatible = "snps,dwmac-mdio";$

WARNING: please, no space before tabs
#39: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:227:
+  ^I^Icompatible = "snps,dwmac-mdio";$

WARNING: please, no spaces at the start of a line
#39: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:227:
+  ^I^Icompatible = "snps,dwmac-mdio";$

ERROR: code indent should use tabs where possible
#40: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:228:
+  ^I  ^I#address-cells = <1>;$

WARNING: please, no space before tabs
#40: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:228:
+  ^I  ^I#address-cells = <1>;$

WARNING: please, no spaces at the start of a line
#40: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:228:
+  ^I  ^I#address-cells = <1>;$

ERROR: code indent should use tabs where possible
#41: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:229:
+  ^I  ^I#size-cells = <0>;$

WARNING: please, no space before tabs
#41: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:229:
+  ^I  ^I#size-cells = <0>;$

WARNING: please, no spaces at the start of a line
#41: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:229:
+  ^I  ^I#size-cells = <0>;$

ERROR: trailing whitespace
#43: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:231:
+  ^I  ^Irgmii_phy: ethernet-phy@7 $

ERROR: code indent should use tabs where possible
#43: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:231:
+  ^I  ^Irgmii_phy: ethernet-phy@7 $

WARNING: please, no space before tabs
#43: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:231:
+  ^I  ^Irgmii_phy: ethernet-phy@7 $

WARNING: please, no spaces at the start of a line
#43: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:231:
+  ^I  ^Irgmii_phy: ethernet-phy@7 $

ERROR: code indent should use tabs where possible
#44: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:232:
+  ^I  ^I{$

WARNING: please, no space before tabs
#44: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:232:
+  ^I  ^I{$

WARNING: please, no spaces at the start of a line
#44: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:232:
+  ^I  ^I{$

WARNING: DT compatible string "ethernet-phy-id2000.a231" appears un-documented -- check ./Documentation/devicetree/bindings/
#45: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:233:
+  	  	  	compatible = "ethernet-phy-id2000.a231";

ERROR: code indent should use tabs where possible
#45: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:233:
+  ^I  ^I  ^Icompatible = "ethernet-phy-id2000.a231";$

WARNING: please, no space before tabs
#45: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:233:
+  ^I  ^I  ^Icompatible = "ethernet-phy-id2000.a231";$

WARNING: please, no spaces at the start of a line
#45: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:233:
+  ^I  ^I  ^Icompatible = "ethernet-phy-id2000.a231";$

ERROR: code indent should use tabs where possible
#46: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:234:
+  ^I  ^I  ^Ireg = <0x7>;$

WARNING: please, no space before tabs
#46: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:234:
+  ^I  ^I  ^Ireg = <0x7>;$

WARNING: please, no spaces at the start of a line
#46: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:234:
+  ^I  ^I  ^Ireg = <0x7>;$

ERROR: code indent should use tabs where possible
#48: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:236:
+  ^I  ^I  ^Ireset-gpios = <&tlmm 105 GPIO_ACTIVE_LOW>;$

WARNING: please, no space before tabs
#48: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:236:
+  ^I  ^I  ^Ireset-gpios = <&tlmm 105 GPIO_ACTIVE_LOW>;$

WARNING: please, no spaces at the start of a line
#48: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:236:
+  ^I  ^I  ^Ireset-gpios = <&tlmm 105 GPIO_ACTIVE_LOW>;$

ERROR: code indent should use tabs where possible
#49: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:237:
+  ^I  ^I  ^Ireset-assert-us = <11000>;$

WARNING: please, no space before tabs
#49: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:237:
+  ^I  ^I  ^Ireset-assert-us = <11000>;$

WARNING: please, no spaces at the start of a line
#49: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:237:
+  ^I  ^I  ^Ireset-assert-us = <11000>;$

ERROR: code indent should use tabs where possible
#50: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:238:
+  ^I  ^I  ^Ireset-deassert-us = <70000>;$

WARNING: please, no space before tabs
#50: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:238:
+  ^I  ^I  ^Ireset-deassert-us = <70000>;$

WARNING: please, no spaces at the start of a line
#50: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:238:
+  ^I  ^I  ^Ireset-deassert-us = <70000>;$

ERROR: code indent should use tabs where possible
#51: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:239:
+  ^I  ^I};$

WARNING: please, no space before tabs
#51: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:239:
+  ^I  ^I};$

WARNING: please, no spaces at the start of a line
#51: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:239:
+  ^I  ^I};$

ERROR: code indent should use tabs where possible
#52: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:240:
+  ^I};$

WARNING: please, no space before tabs
#52: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:240:
+  ^I};$

WARNING: please, no spaces at the start of a line
#52: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:240:
+  ^I};$

ERROR: trailing whitespace
#54: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:242:
+  ^Imtl_rx_setup: rx-queues-config $

ERROR: code indent should use tabs where possible
#54: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:242:
+  ^Imtl_rx_setup: rx-queues-config $

WARNING: please, no space before tabs
#54: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:242:
+  ^Imtl_rx_setup: rx-queues-config $

WARNING: please, no spaces at the start of a line
#54: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:242:
+  ^Imtl_rx_setup: rx-queues-config $

ERROR: code indent should use tabs where possible
#55: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:243:
+  ^I{$

WARNING: please, no space before tabs
#55: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:243:
+  ^I{$

WARNING: please, no spaces at the start of a line
#55: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:243:
+  ^I{$

ERROR: code indent should use tabs where possible
#56: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:244:
+  ^I  ^Isnps,rx-queues-to-use = <1>;$

WARNING: please, no space before tabs
#56: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:244:
+  ^I  ^Isnps,rx-queues-to-use = <1>;$

WARNING: please, no spaces at the start of a line
#56: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:244:
+  ^I  ^Isnps,rx-queues-to-use = <1>;$

ERROR: code indent should use tabs where possible
#57: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:245:
+  ^I  ^Isnps,rx-sched-sp;$

WARNING: please, no space before tabs
#57: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:245:
+  ^I  ^Isnps,rx-sched-sp;$

WARNING: please, no spaces at the start of a line
#57: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:245:
+  ^I  ^Isnps,rx-sched-sp;$

ERROR: trailing whitespace
#59: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:247:
+  ^I  ^Iqueue0 $

ERROR: code indent should use tabs where possible
#59: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:247:
+  ^I  ^Iqueue0 $

WARNING: please, no space before tabs
#59: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:247:
+  ^I  ^Iqueue0 $

WARNING: please, no spaces at the start of a line
#59: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:247:
+  ^I  ^Iqueue0 $

ERROR: code indent should use tabs where possible
#60: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:248:
+  ^I  ^I{$

WARNING: please, no space before tabs
#60: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:248:
+  ^I  ^I{$

WARNING: please, no spaces at the start of a line
#60: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:248:
+  ^I  ^I{$

ERROR: code indent should use tabs where possible
#61: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:249:
+  ^I  ^I  snps,dcb-algorithm;$

WARNING: please, no space before tabs
#61: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:249:
+  ^I  ^I  snps,dcb-algorithm;$

WARNING: please, no spaces at the start of a line
#61: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:249:
+  ^I  ^I  snps,dcb-algorithm;$

ERROR: code indent should use tabs where possible
#62: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:250:
+  ^I  ^I  snps,map-to-dma-channel = <0x0>;$

WARNING: please, no space before tabs
#62: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:250:
+  ^I  ^I  snps,map-to-dma-channel = <0x0>;$

WARNING: please, no spaces at the start of a line
#62: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:250:
+  ^I  ^I  snps,map-to-dma-channel = <0x0>;$

ERROR: code indent should use tabs where possible
#63: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:251:
+  ^I  ^I  snps,route-up;$

WARNING: please, no space before tabs
#63: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:251:
+  ^I  ^I  snps,route-up;$

WARNING: please, no spaces at the start of a line
#63: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:251:
+  ^I  ^I  snps,route-up;$

ERROR: code indent should use tabs where possible
#64: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:252:
+  ^I  ^I  snps,priority = <0x1>;$

WARNING: please, no space before tabs
#64: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:252:
+  ^I  ^I  snps,priority = <0x1>;$

WARNING: please, no spaces at the start of a line
#64: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:252:
+  ^I  ^I  snps,priority = <0x1>;$

ERROR: code indent should use tabs where possible
#65: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:253:
+  ^I  ^I};$

WARNING: please, no space before tabs
#65: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:253:
+  ^I  ^I};$

WARNING: please, no spaces at the start of a line
#65: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:253:
+  ^I  ^I};$

ERROR: code indent should use tabs where possible
#66: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:254:
+  ^I};$

WARNING: please, no space before tabs
#66: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:254:
+  ^I};$

WARNING: please, no spaces at the start of a line
#66: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:254:
+  ^I};$

ERROR: code indent should use tabs where possible
#68: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:256:
+  ^Imtl_tx_setup: tx-queues-config {$

WARNING: please, no space before tabs
#68: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:256:
+  ^Imtl_tx_setup: tx-queues-config {$

WARNING: please, no spaces at the start of a line
#68: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:256:
+  ^Imtl_tx_setup: tx-queues-config {$

ERROR: code indent should use tabs where possible
#69: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:257:
+  ^I  ^Isnps,tx-queues-to-use = <1>;$

WARNING: please, no space before tabs
#69: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:257:
+  ^I  ^Isnps,tx-queues-to-use = <1>;$

WARNING: please, no spaces at the start of a line
#69: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:257:
+  ^I  ^Isnps,tx-queues-to-use = <1>;$

ERROR: code indent should use tabs where possible
#70: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:258:
+  ^I  ^Isnps,tx-sched-wrr;$

WARNING: please, no space before tabs
#70: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:258:
+  ^I  ^Isnps,tx-sched-wrr;$

WARNING: please, no spaces at the start of a line
#70: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:258:
+  ^I  ^Isnps,tx-sched-wrr;$

ERROR: code indent should use tabs where possible
#72: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:260:
+  ^I  ^Iqueue0 {$

WARNING: please, no space before tabs
#72: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:260:
+  ^I  ^Iqueue0 {$

WARNING: please, no spaces at the start of a line
#72: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:260:
+  ^I  ^Iqueue0 {$

ERROR: code indent should use tabs where possible
#73: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:261:
+  ^I  ^I  ^Isnps,weight = <0x10>;$

WARNING: please, no space before tabs
#73: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:261:
+  ^I  ^I  ^Isnps,weight = <0x10>;$

WARNING: please, no spaces at the start of a line
#73: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:261:
+  ^I  ^I  ^Isnps,weight = <0x10>;$

ERROR: code indent should use tabs where possible
#74: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:262:
+  ^I  ^I  ^Isnps,dcb-algorithm;$

WARNING: please, no space before tabs
#74: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:262:
+  ^I  ^I  ^Isnps,dcb-algorithm;$

WARNING: please, no spaces at the start of a line
#74: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:262:
+  ^I  ^I  ^Isnps,dcb-algorithm;$

ERROR: code indent should use tabs where possible
#75: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:263:
+  ^I  ^I  ^Isnps,priority = <0x0>;$

WARNING: please, no space before tabs
#75: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:263:
+  ^I  ^I  ^Isnps,priority = <0x0>;$

WARNING: please, no spaces at the start of a line
#75: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:263:
+  ^I  ^I  ^Isnps,priority = <0x0>;$

ERROR: code indent should use tabs where possible
#76: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:264:
+  ^I  ^I};$

WARNING: please, no space before tabs
#76: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:264:
+  ^I  ^I};$

WARNING: please, no spaces at the start of a line
#76: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:264:
+  ^I  ^I};$

ERROR: code indent should use tabs where possible
#77: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:265:
+  ^I};$

WARNING: please, no space before tabs
#77: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:265:
+  ^I};$

WARNING: please, no spaces at the start of a line
#77: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:265:
+  ^I};$

ERROR: code indent should use tabs where possible
#88: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:405:
+    ^Imdc-pins {$

WARNING: please, no space before tabs
#88: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:405:
+    ^Imdc-pins {$

WARNING: please, no spaces at the start of a line
#88: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:405:
+    ^Imdc-pins {$

ERROR: code indent should use tabs where possible
#89: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:406:
+    ^I  ^Ipins = "gpio113";$

WARNING: please, no space before tabs
#89: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:406:
+    ^I  ^Ipins = "gpio113";$

WARNING: please, no spaces at the start of a line
#89: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:406:
+    ^I  ^Ipins = "gpio113";$

ERROR: code indent should use tabs where possible
#90: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:407:
+    ^I  ^Ifunction = "rgmii";$

WARNING: please, no space before tabs
#90: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:407:
+    ^I  ^Ifunction = "rgmii";$

WARNING: please, no spaces at the start of a line
#90: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:407:
+    ^I  ^Ifunction = "rgmii";$

ERROR: code indent should use tabs where possible
#91: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:408:
+    ^I  ^Ibias-pull-up;$

WARNING: please, no space before tabs
#91: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:408:
+    ^I  ^Ibias-pull-up;$

WARNING: please, no spaces at the start of a line
#91: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:408:
+    ^I  ^Ibias-pull-up;$

ERROR: code indent should use tabs where possible
#92: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:409:
+    ^I};$

WARNING: please, no space before tabs
#92: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:409:
+    ^I};$

WARNING: please, no spaces at the start of a line
#92: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:409:
+    ^I};$

ERROR: code indent should use tabs where possible
#94: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:411:
+    ^Imdio-pins {$

WARNING: please, no space before tabs
#94: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:411:
+    ^Imdio-pins {$

WARNING: please, no spaces at the start of a line
#94: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:411:
+    ^Imdio-pins {$

ERROR: code indent should use tabs where possible
#95: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:412:
+    ^I  ^Ipins = "gpio114";$

WARNING: please, no space before tabs
#95: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:412:
+    ^I  ^Ipins = "gpio114";$

WARNING: please, no spaces at the start of a line
#95: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:412:
+    ^I  ^Ipins = "gpio114";$

ERROR: code indent should use tabs where possible
#96: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:413:
+    ^I  ^Ifunction = "rgmii";$

WARNING: please, no space before tabs
#96: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:413:
+    ^I  ^Ifunction = "rgmii";$

WARNING: please, no spaces at the start of a line
#96: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:413:
+    ^I  ^Ifunction = "rgmii";$

ERROR: code indent should use tabs where possible
#97: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:414:
+    ^I  ^Ibias-pull-up;$

WARNING: please, no space before tabs
#97: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:414:
+    ^I  ^Ibias-pull-up;$

WARNING: please, no spaces at the start of a line
#97: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:414:
+    ^I  ^Ibias-pull-up;$

ERROR: code indent should use tabs where possible
#98: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:415:
+    ^I};$

WARNING: please, no space before tabs
#98: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:415:
+    ^I};$

WARNING: please, no spaces at the start of a line
#98: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:415:
+    ^I};$

ERROR: code indent should use tabs where possible
#101: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:418:
+    ^I  ^Ipins = "gpio121";$

WARNING: please, no space before tabs
#101: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:418:
+    ^I  ^Ipins = "gpio121";$

WARNING: please, no spaces at the start of a line
#101: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:418:
+    ^I  ^Ipins = "gpio121";$

ERROR: code indent should use tabs where possible
#102: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:419:
+    ^I  ^Ifunction = "gpio";$

WARNING: please, no space before tabs
#102: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:419:
+    ^I  ^Ifunction = "gpio";$

WARNING: please, no spaces at the start of a line
#102: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:419:
+    ^I  ^Ifunction = "gpio";$

ERROR: code indent should use tabs where possible
#103: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:420:
+    ^I  ^Ibias-disable;$

WARNING: please, no space before tabs
#103: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:420:
+    ^I  ^Ibias-disable;$

WARNING: please, no spaces at the start of a line
#103: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:420:
+    ^I  ^Ibias-disable;$

ERROR: code indent should use tabs where possible
#104: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:421:
+    ^I  ^Idrive-strength = <8>;$

WARNING: please, no space before tabs
#104: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:421:
+    ^I  ^Idrive-strength = <8>;$

WARNING: please, no spaces at the start of a line
#104: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:421:
+    ^I  ^Idrive-strength = <8>;$

ERROR: code indent should use tabs where possible
#105: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:422:
+    ^I};$

WARNING: please, no space before tabs
#105: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:422:
+    ^I};$

WARNING: please, no spaces at the start of a line
#105: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:422:
+    ^I};$

ERROR: code indent should use tabs where possible
#107: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:424:
+    ^Iphy-reset-pins {$

WARNING: please, no space before tabs
#107: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:424:
+    ^Iphy-reset-pins {$

WARNING: please, no spaces at the start of a line
#107: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:424:
+    ^Iphy-reset-pins {$

ERROR: code indent should use tabs where possible
#108: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:425:
+    ^I  ^Ipins = "gpio105";$

WARNING: please, no space before tabs
#108: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:425:
+    ^I  ^Ipins = "gpio105";$

WARNING: please, no spaces at the start of a line
#108: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:425:
+    ^I  ^Ipins = "gpio105";$

ERROR: code indent should use tabs where possible
#109: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:426:
+    ^I  ^Ifunction = "gpio";$

WARNING: please, no space before tabs
#109: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:426:
+    ^I  ^Ifunction = "gpio";$

WARNING: please, no spaces at the start of a line
#109: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:426:
+    ^I  ^Ifunction = "gpio";$

ERROR: code indent should use tabs where possible
#110: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:427:
+    ^I  ^Ibias-pull-up;$

WARNING: please, no space before tabs
#110: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:427:
+    ^I  ^Ibias-pull-up;$

WARNING: please, no spaces at the start of a line
#110: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:427:
+    ^I  ^Ibias-pull-up;$

ERROR: code indent should use tabs where possible
#111: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:428:
+    ^I  ^Idrive-strength = <16>;$

WARNING: please, no space before tabs
#111: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:428:
+    ^I  ^Idrive-strength = <16>;$

WARNING: please, no spaces at the start of a line
#111: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:428:
+    ^I  ^Idrive-strength = <16>;$

ERROR: code indent should use tabs where possible
#112: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:429:
+    ^I};$

WARNING: please, no space before tabs
#112: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:429:
+    ^I};$

WARNING: please, no spaces at the start of a line
#112: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:429:
+    ^I};$

ERROR: code indent should use tabs where possible
#114: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:431:
+    ^Irgmii-rx-pins {$

WARNING: please, no space before tabs
#114: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:431:
+    ^Irgmii-rx-pins {$

WARNING: please, no spaces at the start of a line
#114: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:431:
+    ^Irgmii-rx-pins {$

ERROR: code indent should use tabs where possible
#115: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:432:
+    ^I  ^Ipins = "gpio81", "gpio82", "gpio83", "gpio102", "gpio103", "gpio112";$

WARNING: please, no space before tabs
#115: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:432:
+    ^I  ^Ipins = "gpio81", "gpio82", "gpio83", "gpio102", "gpio103", "gpio112";$

WARNING: please, no spaces at the start of a line
#115: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:432:
+    ^I  ^Ipins = "gpio81", "gpio82", "gpio83", "gpio102", "gpio103", "gpio112";$

ERROR: code indent should use tabs where possible
#116: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:433:
+    ^I  ^Ifunction = "rgmii";$

WARNING: please, no space before tabs
#116: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:433:
+    ^I  ^Ifunction = "rgmii";$

WARNING: please, no spaces at the start of a line
#116: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:433:
+    ^I  ^Ifunction = "rgmii";$

ERROR: code indent should use tabs where possible
#117: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:434:
+    ^I  ^Ibias-disable;$

WARNING: please, no space before tabs
#117: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:434:
+    ^I  ^Ibias-disable;$

WARNING: please, no spaces at the start of a line
#117: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:434:
+    ^I  ^Ibias-disable;$

ERROR: code indent should use tabs where possible
#118: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:435:
+    ^I  ^Idrive-strength = <2>;$

WARNING: please, no space before tabs
#118: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:435:
+    ^I  ^Idrive-strength = <2>;$

WARNING: please, no spaces at the start of a line
#118: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:435:
+    ^I  ^Idrive-strength = <2>;$

ERROR: code indent should use tabs where possible
#119: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:436:
+    ^I};$

WARNING: please, no space before tabs
#119: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:436:
+    ^I};$

WARNING: please, no spaces at the start of a line
#119: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:436:
+    ^I};$

ERROR: code indent should use tabs where possible
#121: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:438:
+    ^Irgmii-tx-pins {$

WARNING: please, no space before tabs
#121: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:438:
+    ^Irgmii-tx-pins {$

WARNING: please, no spaces at the start of a line
#121: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:438:
+    ^Irgmii-tx-pins {$

ERROR: code indent should use tabs where possible
#122: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:439:
+    ^I  ^Ipins = "gpio92", "gpio93", "gpio94", "gpio95", "gpio96", "gpio97";$

WARNING: please, no space before tabs
#122: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:439:
+    ^I  ^Ipins = "gpio92", "gpio93", "gpio94", "gpio95", "gpio96", "gpio97";$

WARNING: please, no spaces at the start of a line
#122: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:439:
+    ^I  ^Ipins = "gpio92", "gpio93", "gpio94", "gpio95", "gpio96", "gpio97";$

ERROR: code indent should use tabs where possible
#123: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:440:
+    ^I  ^Ifunction = "rgmii";$

WARNING: please, no space before tabs
#123: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:440:
+    ^I  ^Ifunction = "rgmii";$

WARNING: please, no spaces at the start of a line
#123: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:440:
+    ^I  ^Ifunction = "rgmii";$

ERROR: code indent should use tabs where possible
#124: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:441:
+    ^I  ^Ibias-pull-up;$

WARNING: please, no space before tabs
#124: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:441:
+    ^I  ^Ibias-pull-up;$

WARNING: please, no spaces at the start of a line
#124: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:441:
+    ^I  ^Ibias-pull-up;$

ERROR: code indent should use tabs where possible
#125: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:442:
+    ^I  ^Idrive-strength = <16>;$

WARNING: please, no space before tabs
#125: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:442:
+    ^I  ^Idrive-strength = <16>;$

WARNING: please, no spaces at the start of a line
#125: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:442:
+    ^I  ^Idrive-strength = <16>;$

ERROR: code indent should use tabs where possible
#126: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:443:
+    ^I};$

WARNING: please, no space before tabs
#126: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:443:
+    ^I};$

WARNING: please, no spaces at the start of a line
#126: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:443:
+    ^I};$

ERROR: code indent should use tabs where possible
#127: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:444:
+  ^I};$

WARNING: please, no space before tabs
#127: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:444:
+  ^I};$

WARNING: please, no spaces at the start of a line
#127: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi:444:
+  ^I};$

ERROR: trailing whitespace
#161: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk.dts:106:
+^I^Iemac0_phy_en_hog: emac0-phy-en-hog $

ERROR: code indent should use tabs where possible
#163: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk.dts:108:
+      ^I^Igpio-hog;$

WARNING: please, no space before tabs
#163: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk.dts:108:
+      ^I^Igpio-hog;$

WARNING: please, no spaces at the start of a line
#163: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk.dts:108:
+      ^I^Igpio-hog;$

ERROR: code indent should use tabs where possible
#164: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk.dts:109:
+      ^I^Igpios = <6 GPIO_ACTIVE_HIGH>;$

WARNING: please, no space before tabs
#164: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk.dts:109:
+      ^I^Igpios = <6 GPIO_ACTIVE_HIGH>;$

WARNING: please, no spaces at the start of a line
#164: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk.dts:109:
+      ^I^Igpios = <6 GPIO_ACTIVE_HIGH>;$

ERROR: code indent should use tabs where possible
#165: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk.dts:110:
+      ^I^Ioutput-high;$

WARNING: please, no space before tabs
#165: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk.dts:110:
+      ^I^Ioutput-high;$

WARNING: please, no spaces at the start of a line
#165: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk.dts:110:
+      ^I^Ioutput-high;$

ERROR: code indent should use tabs where possible
#166: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk.dts:111:
+      ^I^Iline-name = "emac0-phy-en";$

WARNING: please, no space before tabs
#166: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk.dts:111:
+      ^I^Iline-name = "emac0-phy-en";$

WARNING: please, no spaces at the start of a line
#166: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk.dts:111:
+      ^I^Iline-name = "emac0-phy-en";$

ERROR: code indent should use tabs where possible
#167: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk.dts:112:
+    ^I};$

WARNING: please, no space before tabs
#167: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk.dts:112:
+    ^I};$

WARNING: please, no spaces at the start of a line
#167: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk.dts:112:
+    ^I};$

ERROR: code indent should use tabs where possible
#176: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk.dts:124:
+        status = "okay";$

WARNING: please, no spaces at the start of a line
#176: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk.dts:124:
+        status = "okay";$

ERROR: code indent should use tabs where possible
#180: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk.dts:128:
+        status = "okay";$

WARNING: please, no spaces at the start of a line
#180: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk.dts:128:
+        status = "okay";$

ERROR: code indent should use tabs where possible
#184: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk.dts:132:
+        link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000>;$

WARNING: please, no spaces at the start of a line
#184: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk.dts:132:
+        link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000>;$

ERROR: code indent should use tabs where possible
#185: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk.dts:133:
+        remote-endpoint = <&dp0_connector_in>;$

WARNING: please, no spaces at the start of a line
#185: FILE: arch/arm64/boot/dts/qcom/talos-lyra-evk.dts:133:
+        remote-endpoint = <&dp0_connector_in>;$

ERROR: trailing whitespace
#199: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:689:
+^I^Iethernet: ethernet@20000 $

ERROR: code indent should use tabs where possible
#201: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:691:
+      ^I^Icompatible = "qcom,qcs615-ethqos", "qcom,qcs404-ethqos";$

WARNING: please, no space before tabs
#201: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:691:
+      ^I^Icompatible = "qcom,qcs615-ethqos", "qcom,qcs404-ethqos";$

WARNING: please, no spaces at the start of a line
#201: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:691:
+      ^I^Icompatible = "qcom,qcs615-ethqos", "qcom,qcs404-ethqos";$

ERROR: code indent should use tabs where possible
#202: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:692:
+      ^I^Ireg = <0x0 0x00020000 0x0 0x10000>,$

WARNING: please, no space before tabs
#202: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:692:
+      ^I^Ireg = <0x0 0x00020000 0x0 0x10000>,$

WARNING: please, no spaces at the start of a line
#202: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:692:
+      ^I^Ireg = <0x0 0x00020000 0x0 0x10000>,$

ERROR: code indent should use tabs where possible
#204: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:694:
+      ^I^Ireg-names = "stmmaceth",$

WARNING: please, no space before tabs
#204: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:694:
+      ^I^Ireg-names = "stmmaceth",$

WARNING: please, no spaces at the start of a line
#204: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:694:
+      ^I^Ireg-names = "stmmaceth",$

ERROR: code indent should use tabs where possible
#205: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:695:
+        ^I    ^I^I"rgmii";$

WARNING: please, no space before tabs
#205: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:695:
+        ^I    ^I^I"rgmii";$

WARNING: please, no spaces at the start of a line
#205: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:695:
+        ^I    ^I^I"rgmii";$

ERROR: code indent should use tabs where possible
#207: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:697:
+      ^I^Iclocks = <&gcc GCC_EMAC_AXI_CLK>,$

WARNING: please, no space before tabs
#207: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:697:
+      ^I^Iclocks = <&gcc GCC_EMAC_AXI_CLK>,$

WARNING: please, no spaces at the start of a line
#207: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:697:
+      ^I^Iclocks = <&gcc GCC_EMAC_AXI_CLK>,$

ERROR: code indent should use tabs where possible
#208: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:698:
+^I^I^I^I  ^I <&gcc GCC_EMAC_SLV_AHB_CLK>,$

WARNING: please, no space before tabs
#208: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:698:
+^I^I^I^I  ^I <&gcc GCC_EMAC_SLV_AHB_CLK>,$

ERROR: code indent should use tabs where possible
#209: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:699:
+^I^I^I^I  ^I <&gcc GCC_EMAC_PTP_CLK>,$

WARNING: please, no space before tabs
#209: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:699:
+^I^I^I^I  ^I <&gcc GCC_EMAC_PTP_CLK>,$

ERROR: code indent should use tabs where possible
#210: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:700:
+^I^I^I^I  ^I <&gcc GCC_EMAC_RGMII_CLK>;$

WARNING: please, no space before tabs
#210: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:700:
+^I^I^I^I  ^I <&gcc GCC_EMAC_RGMII_CLK>;$

ERROR: code indent should use tabs where possible
#211: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:701:
+      ^I^Iclock-names = "stmmaceth",$

WARNING: please, no space before tabs
#211: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:701:
+      ^I^Iclock-names = "stmmaceth",$

WARNING: please, no spaces at the start of a line
#211: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:701:
+      ^I^Iclock-names = "stmmaceth",$

ERROR: code indent should use tabs where possible
#212: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:702:
+        ^I      ^I^I"pclk",$

WARNING: please, no space before tabs
#212: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:702:
+        ^I      ^I^I"pclk",$

WARNING: please, no spaces at the start of a line
#212: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:702:
+        ^I      ^I^I"pclk",$

ERROR: code indent should use tabs where possible
#213: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:703:
+        ^I      ^I^I"ptp_ref",$

WARNING: please, no space before tabs
#213: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:703:
+        ^I      ^I^I"ptp_ref",$

WARNING: please, no spaces at the start of a line
#213: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:703:
+        ^I      ^I^I"ptp_ref",$

ERROR: code indent should use tabs where possible
#214: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:704:
+        ^I      ^I^I"rgmii";$

WARNING: please, no space before tabs
#214: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:704:
+        ^I      ^I^I"rgmii";$

WARNING: please, no spaces at the start of a line
#214: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:704:
+        ^I      ^I^I"rgmii";$

ERROR: code indent should use tabs where possible
#216: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:706:
+      ^I^Iinterrupts = <GIC_SPI 660 IRQ_TYPE_LEVEL_HIGH 0>,$

WARNING: please, no space before tabs
#216: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:706:
+      ^I^Iinterrupts = <GIC_SPI 660 IRQ_TYPE_LEVEL_HIGH 0>,$

WARNING: please, no spaces at the start of a line
#216: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:706:
+      ^I^Iinterrupts = <GIC_SPI 660 IRQ_TYPE_LEVEL_HIGH 0>,$

ERROR: code indent should use tabs where possible
#218: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:708:
+      ^I^Iinterrupt-names = "macirq",$

WARNING: please, no space before tabs
#218: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:708:
+      ^I^Iinterrupt-names = "macirq",$

WARNING: please, no spaces at the start of a line
#218: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:708:
+      ^I^Iinterrupt-names = "macirq",$

ERROR: code indent should use tabs where possible
#219: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:709:
+        ^I    ^I^I^I  "eth_lpi";$

WARNING: please, no space before tabs
#219: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:709:
+        ^I    ^I^I^I  "eth_lpi";$

WARNING: please, no spaces at the start of a line
#219: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:709:
+        ^I    ^I^I^I  "eth_lpi";$

ERROR: code indent should use tabs where possible
#221: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:711:
+      ^I^Ipower-domains = <&gcc EMAC_GDSC>;$

WARNING: please, no space before tabs
#221: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:711:
+      ^I^Ipower-domains = <&gcc EMAC_GDSC>;$

WARNING: please, no spaces at the start of a line
#221: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:711:
+      ^I^Ipower-domains = <&gcc EMAC_GDSC>;$

ERROR: code indent should use tabs where possible
#222: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:712:
+      ^I^Iresets = <&gcc GCC_EMAC_BCR>;$

WARNING: please, no space before tabs
#222: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:712:
+      ^I^Iresets = <&gcc GCC_EMAC_BCR>;$

WARNING: please, no spaces at the start of a line
#222: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:712:
+      ^I^Iresets = <&gcc GCC_EMAC_BCR>;$

ERROR: code indent should use tabs where possible
#224: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:714:
+      ^I^Iiommus = <&apps_smmu 0x1c0 0x0>;$

WARNING: please, no space before tabs
#224: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:714:
+      ^I^Iiommus = <&apps_smmu 0x1c0 0x0>;$

WARNING: please, no spaces at the start of a line
#224: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:714:
+      ^I^Iiommus = <&apps_smmu 0x1c0 0x0>;$

ERROR: code indent should use tabs where possible
#226: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:716:
+      ^I^Isnps,tso;$

WARNING: please, no space before tabs
#226: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:716:
+      ^I^Isnps,tso;$

WARNING: please, no spaces at the start of a line
#226: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:716:
+      ^I^Isnps,tso;$

ERROR: code indent should use tabs where possible
#227: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:717:
+      ^I^Isnps,pbl = <32>;$

WARNING: please, no space before tabs
#227: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:717:
+      ^I^Isnps,pbl = <32>;$

WARNING: please, no spaces at the start of a line
#227: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:717:
+      ^I^Isnps,pbl = <32>;$

ERROR: code indent should use tabs where possible
#228: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:718:
+      ^I^Irx-fifo-depth = <16384>;$

WARNING: please, no space before tabs
#228: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:718:
+      ^I^Irx-fifo-depth = <16384>;$

WARNING: please, no spaces at the start of a line
#228: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:718:
+      ^I^Irx-fifo-depth = <16384>;$

ERROR: code indent should use tabs where possible
#229: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:719:
+      ^I^Itx-fifo-depth = <20480>;$

WARNING: please, no space before tabs
#229: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:719:
+      ^I^Itx-fifo-depth = <20480>;$

WARNING: please, no spaces at the start of a line
#229: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:719:
+      ^I^Itx-fifo-depth = <20480>;$

ERROR: code indent should use tabs where possible
#231: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:721:
+      ^I^Istatus = "disabled";$

WARNING: please, no space before tabs
#231: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:721:
+      ^I^Istatus = "disabled";$

WARNING: please, no spaces at the start of a line
#231: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:721:
+      ^I^Istatus = "disabled";$

ERROR: code indent should use tabs where possible
#232: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:722:
+    ^I};$

WARNING: please, no space before tabs
#232: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:722:
+    ^I};$

WARNING: please, no spaces at the start of a line
#232: FILE: arch/arm64/boot/dts/qcom/talos.dtsi:722:
+    ^I};$

total: 115 errors, 212 warnings, 202 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

NOTE: Whitespace errors detected.
      You may wish to use scripts/cleanpatch or scripts/cleanfile

0001-arm64-dts-qcom-add-Talos-Lyra-EVK-DTS-for-ethernet-c.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

@Ajinkya-inchure
Ajinkya-inchure force-pushed the ainchure/talos-lyra-evk-dts-updates branch 6 times, most recently from dbe050a to d1bf3c9 Compare August 28, 2026 12:50
For talos.dtsi, talos-lyra-evk.dts, talos-lyra-evk-som.dtsi
files checkpath was returning errors. Fixed them all together

Signed-off-by: Ajinkya Inchure <[email protected]>
@Ajinkya-inchure
Ajinkya-inchure force-pushed the ainchure/talos-lyra-evk-dts-updates branch from d1bf3c9 to 2ff3702 Compare August 28, 2026 12:55
Adding DTS changes for enabling ethernet on talos-lyra board
with TI PHY being used

Signed-off-by: Ajinkya Inchure <[email protected]>
@Ajinkya-inchure
Ajinkya-inchure force-pushed the ainchure/talos-lyra-evk-dts-updates branch from c6d1022 to 5036b20 Compare August 28, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants