Repository navigation
Reject empty ids instead of dropping their request path segment - #114
Merged
Merged
Conversation
An id that is empty or whitespace-only produced the collection route
(for example /v3/users instead of /v3/users/{id}), because buildUrl
drops an empty encoded path and identify('') is validated nowhere. The
same guard that rejects "." and ".." now rejects an id that trims to
nothing, with QonversionErrorCode.InvalidArgument.
Co-Authored-By: Claude Fable 5.1 <[email protected]>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #111. An id that is empty or whitespace-only was sent as no path segment at all:
buildUrldrops an empty encoded path, so/v3/users/{id}became/v3/users(the collection route), andidentify('')is validated nowhere. It is the same class of problem as the.and..ids that #111 rejects.The guard in
RequestConfiguratorImpl.encodePathSegmentnow also rejects an id that trims to nothing, withQonversionErrorCode.InvalidArgumentand a fixed message;a.b,...xand other ordinary ids are encoded as before. The enum member's comment names the empty id as well.Tests: the existing dot-id case table gains
''and' ', checked against all six id-taking request builders.Verified locally with Node 22.23.4 / Yarn 1.22.22:
yarn lint,yarn build,yarn test(29 suites, 287 tests).🤖 Generated with Claude Code