Repository navigation
Fix edge cases in conversions, padding, and percent literals - #110
Merged
Merged
Conversation
Also update AGENTS files with new information
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
==========================================
+ Coverage 95.92% 96.47% +0.54%
==========================================
Files 5 5
Lines 614 652 +38
==========================================
+ Hits 589 629 +40
+ Misses 25 23 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is on top of #108. Claude identified various bugs in the code or things that were not yet implemented. Claude wrote most of the code here with review and suggestions from me. Each commit after the ones in #108 are deliberately separate for each issue that Claude identified. All the issues are edge cases where we're very unlikely to run into these things in our main use cases (i.e. satpy). Here is my summary:
%%in a date format it was sometimes mishandled. Like%Y%%m%d. That%%should be turned into a single%as per the strftime/datetime spec, but trollsift would match the%minstead. The result is a difference between "2026%m08" (correct) versus "2026%0908". Again, who does this? But it was wrong. This was also the most annoying as far as how much code change had to happen for such a simple fix.