gh-73126: Don't fail early when __length_hint__() is too big for preallocation. - #8635
Closed
sir-sigurd wants to merge 2 commits into
Closed
gh-73126: Don't fail early when __length_hint__() is too big for preallocation.#8635sir-sigurd wants to merge 2 commits into
sir-sigurd wants to merge 2 commits into
Conversation
| if (result == NULL) { | ||
| /* bpo-28940 - LengthHint could lie and asked for too much, | ||
| * try again without preallocation. */ | ||
| PyErr_Clear(); |
Contributor
There was a problem hiding this comment.
This will silence any possible exception raised in PyTuple_New() (same for PyByteArray_FromStringAndSize(), _PyBytesWriter_Alloc(), etc.). I don't think that's the right approach.
|
This PR is stale because it has been open for 30 days with no activity. |
picnixz
changed the title
github-actions
Bot
removed
the
stale
|
This PR is stale because it has been open for 30 days with no activity. |
# Conflicts: # Lib/test/test_bytes.py # Lib/test/test_tuple.py # Objects/abstract.c # Objects/bytesobject.c # Objects/listobject.c
Member
|
The problem with this approach is that it only helps when the allocation fails immediately. A hint which is not large enough to fail, but large enough to exhaust memory and swap, is worse, and it would not be handled. There are three alternatives:
Thank you for the patch anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue28940