gh-85260: Extend the AST Validator to validate all identifiers - #21069
Open
isidentical wants to merge 3 commits into
Open
gh-85260: Extend the AST Validator to validate all identifiers#21069isidentical wants to merge 3 commits into
isidentical wants to merge 3 commits into
Conversation
iritkatriel
reviewed
Aug 14, 2020
| static int | ||
| validate_name(PyObject *name) | ||
| validate_name(const char* owner, PyObject *name) | ||
| { |
Member
There was a problem hiding this comment.
In validate_name owner is the first arg and in validate_import_names it is the last arg.
Member
There was a problem hiding this comment.
Other arguments besides owner are different in validate_name() and validate_import_names(), so I do not see a problem here.
Contributor
|
@isidentical Could you resolve the conflicts? |
iritkatriel
added
the
interpreter-core
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
LGTM. Please resolve conflicts.
| static int | ||
| validate_name(PyObject *name) | ||
| validate_name(const char* owner, PyObject *name) | ||
| { |
Member
There was a problem hiding this comment.
Other arguments besides owner are different in validate_name() and validate_import_names(), so I do not see a problem here.
|
This PR is stale because it has been open for 30 days with no activity. |
# Conflicts: # Lib/test/test_ast.py # Misc/NEWS.d/next/Core_and_Builtins/2020-06-23-13-59-37.bpo-41088.o_LJ76.rst # Python/ast.c
serhiy-storchaka
requested review from
Eclips4,
JelleZijlstra and
tomasr8
as code owners
August 11, 2026 20:05
serhiy-storchaka
changed the title
The change is for pythongh-85260 (bpo-41088), not pythongh-85270 (bpo-41098). Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
serhiy-storchaka
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue41088