Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Lib/test/test_capi/test_float.py
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,8 @@ def test_pack_unpack_roundtrip_for_nans(self):
value = unpack(data1, endian)
data2 = pack(size, value, endian)
self.assertTrue(math.isnan(value))
self.assertEqual(math.copysign(1.0, value),
-1.0 if sign else 1.0)
self.assertEqual(data1, data2)

@unittest.skipUnless(HAVE_IEEE_754, "requires IEEE 754")
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
If available on the platform, use native :c:type:`_Float16` in
:c:func:`PyFloat_Pack2` and :c:func:`PyFloat_Unpack2` functions. Patch by
Sergey B Kirpichev.
45 changes: 45 additions & 0 deletions Objects/floatobject.c
Original file line number Diff line number Diff line change
Expand Up @@ -1895,6 +1895,30 @@ int
PyFloat_Pack2(double x, char *data, int le)
{
unsigned char *p = (unsigned char *)data;
#if HAVE_FLOAT16
if (!isnan(x)) {
_Float16 y = (_Float16)x;
int i, incr = 1;

if (isinf(y) && !isinf(x)) {
goto Overflow;
}

unsigned char s[sizeof(_Float16)];
memcpy(s, &y, sizeof(_Float16));

if ((_PY_FLOAT_LITTLE_ENDIAN && !le) || (_PY_FLOAT_BIG_ENDIAN && le)) {
p += 1;
incr = -1;
}

for (i = 0; i < 2; i++) {
*p = s[i];
p += incr;
}
return 0;
}
#endif
unsigned char sign;
int e;
double f;
Expand Down Expand Up @@ -2090,6 +2114,27 @@ double
PyFloat_Unpack2(const char *data, int le)
{
unsigned char *p = (unsigned char *)data;
#if HAVE_FLOAT16
_Float16 x16;

if ((_PY_FLOAT_LITTLE_ENDIAN && !le) || (_PY_FLOAT_BIG_ENDIAN && le)) {
char buf[2];
char *d = &buf[1];
int i;

for (i = 0; i < 2; i++) {
*d-- = *p++;
}
memcpy(&x16, buf, 2);
}
else {
memcpy(&x16, p, 2);
}
if (!isnan(x16)) {
return x16;
}
p = (unsigned char *)data;
#endif
unsigned char sign;
int e;
unsigned int f;
Expand Down
59 changes: 59 additions & 0 deletions configure

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 19 additions & 0 deletions configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -4463,6 +4463,25 @@ if test "$ac_cv_ffi_complex_double_supported" = "yes"; then
[Defined if _Complex C type can be used with libffi.])
fi

# Check for native half-float type.
AC_CACHE_CHECK([for _Float16 support], [ac_cv_float16_supported],
WITH_SAVE_ENV([
CFLAGS="$CFLAGS -O0"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you change the compiler flags?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To disable optimizations.

AC_RUN_IFELSE([AC_LANG_SOURCE([[
int main(void)
{
_Float16 val = 1.0f16;
double d = 3.14;
val = d;
return 0;
}
]])], [ac_cv_float16_supported=yes],
[ac_cv_float16_supported=no],
[ac_cv_float16_supported=no])]))
AS_VAR_IF([ac_cv_float16_supported], [yes],
[AC_DEFINE([HAVE_FLOAT16], [1],
[Defined if _Float16 C type is supported])])

dnl Check for libmpdec >= 2.5.0
PKG_CHECK_MODULES([LIBMPDEC], [libmpdec >= 2.5.0], [have_mpdec=yes], [
WITH_SAVE_ENV([
Expand Down
3 changes: 3 additions & 0 deletions pyconfig.h.in
Original file line number Diff line number Diff line change
Expand Up @@ -497,6 +497,9 @@
/* Define if you have the 'ffi_prep_closure_loc' function. */
#undef HAVE_FFI_PREP_CLOSURE_LOC

/* Defined if _Float16 C type is supported */
#undef HAVE_FLOAT16

/* Define to 1 if you have the 'flock' function. */
#undef HAVE_FLOCK

Expand Down
Loading