-
-
Notifications
You must be signed in to change notification settings - Fork 35.2k
gh-153740: Optimize PyFloat_Pack/Unpack2 using native _Float16 #154796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
skirpichev
wants to merge
21
commits into
python:main
Choose a base branch
from
skirpichev:use-_Float16/153740
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
502589d
gh-153740: use native _Float16 in PyFloat_Pack/Unpack2
skirpichev d90dafb
+1
skirpichev 8bda53a
+ test conversion from double
skirpichev 7f7b1c4
Merge branch 'master' into use-_Float16/153740
skirpichev ac38cb8
+ -O0
skirpichev 5d88691
Merge branch 'master' into use-_Float16/153740
skirpichev a8aa77a
drop -mf16c
skirpichev 7267d2d
+1
skirpichev 00d48b7
add risc-v workaround
skirpichev 702b888
Merge branch 'master' into use-_Float16/153740
skirpichev d7a79fa
+1
skirpichev 7776661
+ test sign of nan value
skirpichev 272c538
+ cast
skirpichev eb06f94
Merge branch 'master' into use-_Float16/153740
skirpichev f2770cb
+1
skirpichev 6bfff56
+1
skirpichev d5b2feb
Merge branch 'master' into use-_Float16/153740
skirpichev 972124e
address review
skirpichev 0358727
Merge branch 'master' into use-_Float16/153740
skirpichev 924fd20
address review: use old code to handle NaN's
skirpichev e416b31
Update Objects/floatobject.c
skirpichev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
Misc/NEWS.d/next/C_API/2026-07-28-04-29-52.gh-issue-153740.7_LMSA.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| If available on the platform, use native :c:type:`_Float16` in | ||
| :c:func:`PyFloat_Pack2` and :c:func:`PyFloat_Unpack2` functions. Patch by | ||
| Sergey B Kirpichev. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you change the compiler flags?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To disable optimizations.