gh-153795: Stop urllib.robotparser.can_fetch crashing on a malformed URL#153796
Open
tonghuaroot wants to merge 1 commit into
Open
gh-153795: Stop urllib.robotparser.can_fetch crashing on a malformed URL#153796tonghuaroot wants to merge 1 commit into
tonghuaroot wants to merge 1 commit into
Conversation
…ormed URL RobotFileParser.can_fetch() is documented to return a bool, but it passed the url straight to urllib.parse._urlsplit(), so a malformed url such as an unterminated IPv6 authority raised a bare ValueError out of can_fetch(). Treat a url that cannot be parsed as matching no rule and return True, matching RFC 9309's default that access is not restricted when no rule applies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RobotFileParser.can_fetch()is documented to return a bool, but it passed the url straight tourllib.parse._urlsplit(), so a malformed url (an unterminated IPv6 authority) raised a bareValueError. Treat a url that cannot be parsed as matching no rule and returnTrue, matching RFC 9309's default that access is not restricted when no rule applies. Thetrywraps only the_urlsplit()call. Sibling of #153404 (same crash class from the robots.txt content side).